You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by vi...@apache.org on 2014/09/03 11:03:54 UTC
svn commit: r1622187 - in /tomcat/trunk:
java/org/apache/catalina/valves/ExtendedAccessLogValve.java
webapps/docs/changelog.xml
Author: violetagg
Date: Wed Sep 3 09:03:54 2014
New Revision: 1622187
URL: http://svn.apache.org/r1622187
Log:
Correct the information written by ExtendedAccessLogValve when a format token x-O(XXX) is used so that multiple values for a header XXX are separated by commas. Identified by Coverity Scan.
Modified:
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=1622187&r1=1622186&r2=1622187&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java Wed Sep 3 09:03:54 2014
@@ -339,7 +339,9 @@ public class ExtendedAccessLogValve exte
StringBuilder buffer = new StringBuilder();
boolean first = true;
while (iter.hasNext()) {
- if (!first) {
+ if (first) {
+ first = false;
+ } else {
buffer.append(",");
}
buffer.append(iter.next());
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1622187&r1=1622186&r2=1622187&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Sep 3 09:03:54 2014
@@ -88,6 +88,12 @@
Fixed the multipart elements merge operation performed during web
application deployment. Identified by Coverity Scan. (violetagg)
</fix>
+ <fix>
+ Correct the information written by
+ <code>ExtendedAccessLogValve</code> when a format token x-O(XXX) is
+ used so that multiple values for a header XXX are separated by commas.
+ Identified by Coverity Scan. (violetagg)
+ </fix>
</changelog>
</subsection>
<subsection name="Jasper">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org