You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/26 20:53:11 UTC
[GitHub] [tvm] comaniac opened a new pull request, #12912: [Relay][TE] Add default param name if needed
comaniac opened a new pull request, #12912:
URL: https://github.com/apache/tvm/pull/12912
#10516 used the Relay parameter name when lowering to TE. However, this creates an issue when the parameter name is empty. This is legal in Relay, but results in errors during code generation. For example, this is the generated CUDA kernel for bias add:
```
extern "C" __global__ void __launch_bounds__(1024) fused_raf_op_tvm_add_kernel0(
float* __restrict__ T_add,
float* __restrict__ , /* Name is missing and it results in compile errors. */
float* __restrict__ _1) {
T_add[((((int)blockIdx.x) * 1024) + ((int)threadIdx.x))] = ([((((int)blockIdx.x) * 1024) + ((int)threadIdx.x))] + _1[((((((int)blockIdx.x) * 16) + (((int)threadIdx.x) >> 6)) % 54) / 9)]);
}
```
This PR adds "placeholder" back as a default to make sure no empty string will be passed when lowering to TE.
cc @Lunderberg @tkonolige
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #12912: [Relay][TE] Add default param name if needed
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #12912:
URL: https://github.com/apache/tvm/pull/12912#issuecomment-1259612845
Thank you for the catch! Is there a test that should have caught this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12912: [Relay][TE] Add default param name if needed
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12912:
URL: https://github.com/apache/tvm/pull/12912#issuecomment-1259717798
Agreed with @Lunderberg! Perhaps a regression test will be helpful (I don't know how hard it is to do so though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao merged pull request #12912: [Relay][TE] Add default param name if needed
Posted by GitBox <gi...@apache.org>.
junrushao merged PR #12912:
URL: https://github.com/apache/tvm/pull/12912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org