You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2012/08/30 20:43:47 UTC
[Bug 53803] New: performance problem in IdentityStack.retainAll()
https://issues.apache.org/bugzilla/show_bug.cgi?id=53803
Priority: P2
Bug ID: 53803
Assignee: notifications@ant.apache.org
Summary: performance problem in IdentityStack.retainAll()
Severity: normal
Classification: Unclassified
OS: Linux
Reporter: nistor1@illinois.edu
Hardware: PC
Status: NEW
Version: 1.8.4
Component: Core
Product: Ant
Created attachment 29310
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29310&action=edit
patch
IdentityStack.retainAll() has the same performance problem as the
previously fixed Bug 53622 (for VectorSet.retainAll()). I attached a
patch similar to the one used by Jesse Glick in Bug 53622. I also
attached a test that exposes this problem. For this test, the patch
provides a 12X speedup on my machine.
To run the test, just do:
$ java Test
The output for the un-patched version is:
Time is 2758
The output for the patched version is:
Time is 225
Similarly to Bug 53622, the problem is that "retainAll(Collection<?> c)"
performs "c.contains(e.next())", which is slow if for example "c" is a
list.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53803] performance problem in IdentityStack.retainAll()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53803
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.9.0 |1.9.1
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53803] performance problem in IdentityStack.retainAll()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53803
Adrian Nistor <ni...@illinois.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nistor1@illinois.edu
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53803] performance problem in IdentityStack.retainAll()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53803
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |1.9.4
--- Comment #2 from Stefan Bodewig <bo...@apache.org> ---
svn revision 1554830
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53803] performance problem in IdentityStack.retainAll()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53803
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.8.4 |1.9.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53803] performance problem in IdentityStack.retainAll()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53803
Jesse Glick <jg...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53803] performance problem in IdentityStack.retainAll()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53803
--- Comment #1 from Adrian Nistor <ni...@illinois.edu> ---
Created attachment 29311
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29311&action=edit
test
--
You are receiving this mail because:
You are the assignee for the bug.