[GitHub] [tvm] tqchen commented on a diff in pull request #12066: Unify name mangling in TVM

[GitBox <gi...@apache.org>]

tqchen commented on code in PR #12066:
URL: https://github.com/apache/tvm/pull/12066#discussion_r918985652


##########
include/tvm/ir/module.h:
##########
@@ -64,6 +65,8 @@ class IRModuleNode : public Object {
   /* \brief Additional attributes storing meta-data about the module. */
   DictAttrs attrs;
 
+  GlobalVarSupply global_var_supply;

Review Comment:
   Given that we can recreate GlobalVarSupply from the current IRModule, and we don't need global var renaming for most of the passes(that only do local edits of functions).
   
   It might make sense to create helper method to generate GlobalVarSupply rather than maintaining as a member of IRModule when needed, to keep the main IRModule data structure simple. 
   
   Doing so would also simplify the serialization part of IRModule, right now the unordered map data structure is not serialized, as a result save_json/load_json of IRModule will no longer work if we make it as a member.
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org