You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tez.apache.org by "Jeff Zhang (JIRA)" <ji...@apache.org> on 2014/11/05 03:07:35 UTC
[jira] [Comment Edited] (TEZ-1724) Refactoring - Consolidate
ROOT_INPUT and INPUT
[ https://issues.apache.org/jira/browse/TEZ-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197313#comment-14197313 ]
Jeff Zhang edited comment on TEZ-1724 at 11/5/14 2:07 AM:
----------------------------------------------------------
[~sseth], after a second thought, I think here ROOT_INPUT maybe mean the input is on the root rather than from other vertex, it should make sense to call it ROOT_INPUT in that case, and it would consistent with the API RootInputLeafOutput, what do you think ?
e.g.
{code}
input1
|
v1 input2
\ |
v2
\
v3
{code}
was (Author: zjffdu):
[~sseth], after a second thought, I think here ROOT_INPUT maybe mean the input is on the root rather than from other vertex, it should make sense to call it ROOT_INPUT in that case, and it would consistent with the API RootInputLeafOutput, what do you think ?
> Refactoring - Consolidate ROOT_INPUT and INPUT
> ----------------------------------------------
>
> Key: TEZ-1724
> URL: https://issues.apache.org/jira/browse/TEZ-1724
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.5.1
> Reporter: Jeff Zhang
>
> Some places we use ROOT_INPUT , while other places we use INPUT (Actually Input can been attached to one non-root-vertex, so I think we need to consolidate them both to INPUT). Here're some places need to refractor.
> * RootInputInitializerManager -> InputInitializerManager
> * TezRootInputInitializerContextImpl -> TezInputInitializerContextImpl
> * VertexEventRootInputInitialized -> VertexEventInputInitialized
> * VertexEventRootInputFailed -> VertexEventInputFailed
> * VertexTerminationCause.ROOT_INPUT_INIT_FAILURE -> VertexTerminationCause.INPUT_INIT_FAILURE.
> * EventType.ROOT_INPUT_DATA_INFORMATION_EVENT -> EventType.INPUT_DATA_INFORMATION_EVENT
> * EventType.ROOT_INPUT_INITIALIZER_EVENT -> EventType.INPUT_INITIALIZER_EVENT
> * VertexEventType.V_ROOT_INPUT_INITIALIZED -> VertexEventType.V_INPUT_INITIALIZED
> * VertexEventType.V_ROOT_INPUT_FAILED -> VertexEventType.V_INPUT_INIT_FAILED
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)