You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/03/16 20:59:36 UTC
[GitHub] [incubator-pinot] icefury71 opened a new pull request #6685: Adding a cluster wide config property to control Cluster Manager UI v…
icefury71 opened a new pull request #6685:
URL: https://github.com/apache/incubator-pinot/pull/6685
…iew (QueryConsole only or everything)
## Description
Related to #6619 . This is used to configure cluster manager to only show query console for many customers that don't want to expose other things such as Zookeeper/Admin operation/Swagger to their users.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade?
No
Does this PR fix a zero-downtime upgrade introduced earlier?
No
Does this PR otherwise need attention when creating release notes?
Yes
## Release Notes
* Added a new cluster config: `queryConsoleOnlyView` which if set to true will result in Cluster Manager UI only displaying the query console and hiding everything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6685: Adding a cluster wide config property to control Cluster Manager UI v…
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #6685:
URL: https://github.com/apache/incubator-pinot/pull/6685#issuecomment-800633318
> > Isnt it better to have a property called clusterUI and set it to different modes? Query-only can be one mode, The next level can be query and data push and the next level can be to change table properties and the one after that will. be cluster admin,
>
> Good point - on that note - the more comprehensive solution will be to integrate UI with the AuthN/Z scheme Alex is working on (in conjunction with something like RBAC). We should discuss that in detail once the backend is ready. Adding flags for all such combinations might be a bit of an overhead.
Exactly. So, just add a UIMode. For starters, we will recognize an unset field (meaning all are allowed) or "QueryConsoleOnly".
Another way to do this will be to provide different http endpoints for the capabilities, but if we wanted step-wise capability, this will be a lot more code (or at least instances of code) but then may provide an easier path towards password on the console? (not sure)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] icefury71 commented on pull request #6685: Adding a cluster wide config property to control Cluster Manager UI v…
Posted by GitBox <gi...@apache.org>.
icefury71 commented on pull request #6685:
URL: https://github.com/apache/incubator-pinot/pull/6685#issuecomment-800638140
> > > Isnt it better to have a property called clusterUI and set it to different modes? Query-only can be one mode, The next level can be query and data push and the next level can be to change table properties and the one after that will. be cluster admin,
> >
> >
> > Good point - on that note - the more comprehensive solution will be to integrate UI with the AuthN/Z scheme Alex is working on (in conjunction with something like RBAC). We should discuss that in detail once the backend is ready. Adding flags for all such combinations might be a bit of an overhead.
>
> Exactly. So, just add a UIMode. For starters, we will recognize an unset field (meaning all are allowed) or "QueryConsoleOnly".
>
> Another way to do this will be to provide different http endpoints for the capabilities, but if we wanted step-wise capability, this will be a lot more code (or at least instances of code) but then may provide an easier path towards password on the console? (not sure)
We don't need to rely on flags for the advanced controls. For eg: Alex's PR adds an API for exposing the security capability configured within Pinot (None, Basic, OAuth2, ...). Cluster Manager should be able to use that API and figure out what needs to be done. Eg: for "Basic" -> display a login screen for username and password (in fact this PR is in progress as we speak).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6685: Adding a cluster wide config property to control Cluster Manager UI v…
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on pull request #6685:
URL: https://github.com/apache/incubator-pinot/pull/6685#issuecomment-800619799
Isnt it better to have a property called clusterUI and set it to different modes? Query-only can be one mode, The next level can be query and data push and the next level can be to change table properties and the one after that will. be cluster admin,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] icefury71 commented on pull request #6685: Adding a cluster wide config property to control Cluster Manager UI v…
Posted by GitBox <gi...@apache.org>.
icefury71 commented on pull request #6685:
URL: https://github.com/apache/incubator-pinot/pull/6685#issuecomment-800622763
> Isnt it better to have a property called clusterUI and set it to different modes? Query-only can be one mode, The next level can be query and data push and the next level can be to change table properties and the one after that will. be cluster admin,
Good point - on that note - the more comprehensive solution will be to integrate UI with the AuthN/Z scheme Alex is working on (in conjunction with something like RBAC). We should discuss that in detail once the backend is ready. Adding flags for all such combinations might be a bit of an overhead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org