You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sanjeev n <sa...@citrix.com> on 2013/10/18 11:27:13 UTC
Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Repository: cloudstack-git
Description
-------
Added following code in the existing test
1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
2.Added test to verify ip alias removal after destroying last vm in the cidr
3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
Diffs
-----
test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
Diff: https://reviews.apache.org/r/14737/diff/
Testing
-------
Yes
Thanks,
sanjeev n
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
> On Oct. 21, 2013, 7:19 a.m., SrikanteswaraRao Talluri wrote:
> > test/integration/component/maint/test_multiple_ip_ranges.py, line 150
> > <https://reviews.apache.org/r/14737/diff/1/?file=366277#file366277line150>
> >
> > Skip the test if the zone.networktype is not basic.
> >
> > if cls.zone.networktype == 'Basic':
> > cls.new_vlan = PublicIpRange.create(cls.api_client, cls.services["vlan_ip_range"])
> > else:
> > self.skipTest("This test can be run only on basic zone")
Oh this is in setupclass, you can use this
if cls.zone.networktype == 'Basic':
cls.new_vlan = PublicIpRange.create(cls.api_client, cls.services["vlan_ip_range"])
else:
raise unittest.SkipTest("This can be run only on basic zone only")
- SrikanteswaraRao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27231
-----------------------------------------------------------
On Oct. 18, 2013, 9:27 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 9:27 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27231
-----------------------------------------------------------
test/integration/component/maint/test_multiple_ip_ranges.py
<https://reviews.apache.org/r/14737/#comment53039>
Remove this line
test/integration/component/maint/test_multiple_ip_ranges.py
<https://reviews.apache.org/r/14737/#comment53043>
Skip the test if the zone.networktype is not basic.
if cls.zone.networktype == 'Basic':
cls.new_vlan = PublicIpRange.create(cls.api_client, cls.services["vlan_ip_range"])
else:
self.skipTest("This test can be run only on basic zone")
- SrikanteswaraRao Talluri
On Oct. 18, 2013, 9:27 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 9:27 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27519
-----------------------------------------------------------
Commit 2103068816d024cf090797168bfd309b031e3e1c in branch refs/heads/master from sanjeevneelarapu
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2103068 ]
CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot
CLOUDSTACK-702: Test for verifying ip alias after VR stop start
1.Deploy vm in new cidr which will create ip alias on existing VR
Stop,start VR and verify ip alias
Conflicts:
test/integration/component/maint/test_multiple_ip_ranges.py
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>
- ASF Subversion and Git Services
On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27520
-----------------------------------------------------------
committed to master : 2103068816d024cf090797168bfd309b031e3e1c
4.2 -> d50e6a5b3ec63d1ff6dd4030ec2325c2bdb13307
- SrikanteswaraRao Talluri
On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27240
-----------------------------------------------------------
Ship it!
Ship It!
- SrikanteswaraRao Talluri
On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27516
-----------------------------------------------------------
Commit d50e6a5b3ec63d1ff6dd4030ec2325c2bdb13307 in branch refs/heads/4.2 from sanjeevneelarapu
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d50e6a5 ]
CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot
CLOUDSTACK-702: Test for verifying ip alias after VR stop start
1.Deploy vm in new cidr which will create ip alias on existing VR
Stop,start VR and verify ip alias
Conflicts:
test/integration/component/maint/test_multiple_ip_ranges.py
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>
- ASF Subversion and Git Services
On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27517
-----------------------------------------------------------
Commit d50e6a5b3ec63d1ff6dd4030ec2325c2bdb13307 in branch refs/heads/4.2 from sanjeevneelarapu
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d50e6a5 ]
CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot
CLOUDSTACK-702: Test for verifying ip alias after VR stop start
1.Deploy vm in new cidr which will create ip alias on existing VR
Stop,start VR and verify ip alias
Conflicts:
test/integration/component/maint/test_multiple_ip_ranges.py
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>
- ASF Subversion and Git Services
On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/#review27518
-----------------------------------------------------------
Commit 2103068816d024cf090797168bfd309b031e3e1c in branch refs/heads/master from sanjeevneelarapu
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2103068 ]
CLOUDSTACK-702: Added tests for alias ip verifications on VR 1. Moved vm deployment code to setup and vm deletion code teadDown methods 2. Added two tests which would verify alias removal after last vm expunge in CIDR and alias status after VR reboot
CLOUDSTACK-702: Test for verifying ip alias after VR stop start
1.Deploy vm in new cidr which will create ip alias on existing VR
Stop,start VR and verify ip alias
Conflicts:
test/integration/component/maint/test_multiple_ip_ranges.py
Signed-off-by: SrikanteswaraRao Talluri <ta...@apache.org>
- ASF Subversion and Git Services
On Oct. 21, 2013, 9:29 a.m., sanjeev n wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14737/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2013, 9:29 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Added following code in the existing test
> 1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
> 2.Added test to verify ip alias removal after destroying last vm in the cidr
> 3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
>
> Diff: https://reviews.apache.org/r/14737/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> sanjeev n
>
>
Re: Review Request 14737: CLOUDSTACK-702: IP alias verification tests on VR
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14737/
-----------------------------------------------------------
(Updated Oct. 21, 2013, 9:29 a.m.)
Review request for cloudstack and SrikanteswaraRao Talluri.
Changes
-------
Incorporated the review comments.
Repository: cloudstack-git
Description
-------
Added following code in the existing test
1.Moved vm deployment code to setUp method and vm destroy code to tearDown method
2.Added test to verify ip alias removal after destroying last vm in the cidr
3.Added tests to verify ip alias verification on VR after reboot and stop/start VR
Diffs (updated)
-----
test/integration/component/maint/test_multiple_ip_ranges.py 3f0035e
Diff: https://reviews.apache.org/r/14737/diff/
Testing
-------
Yes
Thanks,
sanjeev n