You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/11 14:53:38 UTC

[GitHub] tillrohrmann opened a new pull request #6827: [FLINK-10530][tests] Harden ProcessFailureCancelingITCase and AbstractTaskManagerProcessFailureRecovery

tillrohrmann opened a new pull request #6827: [FLINK-10530][tests] Harden ProcessFailureCancelingITCase and AbstractTaskManagerProcessFailureRecovery
URL: https://github.com/apache/flink/pull/6827
 
 
   ## What is the purpose of the change
   
   
   The problem is that the Dispatcher actor is being started before it gains leadership. When using the
   standalone high availability services, then we don't wait until the Dispatcher has confirmed its
   leader session id. We only wait until the actor has become available. Due to that it can happen that
   we try to send a RPC message to the Dispatcher before it has actually set its leader session id.
   
   This commit adds a helper function which waits until the Dispatcher has become available and has set
   its leader session id. The proper way to handle this situation would be to move the leader ship grant
   and revokal out of the Dispatcher into a DispatcherRunner which creates a Dispatcher actor once it
   gained leadership.
   
   ## Verifying this change
   
   - Covered by the hardened tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services