You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2014/06/23 18:46:03 UTC

svn commit: r1604875 - /pdfbox/branches/1.8/jempbox/src/main/java/org/apache/jempbox/xmp/XMPMetadata.java

Author: lehmi
Date: Mon Jun 23 16:46:03 2014
New Revision: 1604875

URL: http://svn.apache.org/r1604875
Log:
PDFBOX-1055: optimize getSchemasByNamespaceURI() implementation as proposed by Philip Helger

Modified:
    pdfbox/branches/1.8/jempbox/src/main/java/org/apache/jempbox/xmp/XMPMetadata.java

Modified: pdfbox/branches/1.8/jempbox/src/main/java/org/apache/jempbox/xmp/XMPMetadata.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/1.8/jempbox/src/main/java/org/apache/jempbox/xmp/XMPMetadata.java?rev=1604875&r1=1604874&r2=1604875&view=diff
==============================================================================
--- pdfbox/branches/1.8/jempbox/src/main/java/org/apache/jempbox/xmp/XMPMetadata.java (original)
+++ pdfbox/branches/1.8/jempbox/src/main/java/org/apache/jempbox/xmp/XMPMetadata.java Mon Jun 23 16:46:03 2014
@@ -667,8 +667,6 @@ public class XMPMetadata
     public List<XMPSchema> getSchemasByNamespaceURI(String namespaceURI)
             throws IOException
     {
-
-        List<XMPSchema> l = getSchemas();
         List<XMPSchema> result = new LinkedList<XMPSchema>();
 
         Class<?> schemaClass = nsMappings.get(namespaceURI);
@@ -677,11 +675,10 @@ public class XMPMetadata
             return result;
         }
 
-        Iterator<XMPSchema> i = l.iterator();
+        Iterator<XMPSchema> i = getSchemas().iterator();
         while (i.hasNext())
         {
             XMPSchema schema = i.next();
-
             if (schemaClass.isAssignableFrom(schema.getClass()))
             {
                 result.add(schema);