[GitHub] [kafka] chia7712 commented on a diff in pull request #13379: KAFKA-14799: Ignore source task requests to abort empty transactions

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #13379:
URL: https://github.com/apache/kafka/pull/13379#discussion_r1133265858


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java:
##########
@@ -483,15 +483,19 @@ protected boolean shouldCommitTransactionForRecord(SourceRecord record) {
                         if (transactionContext.shouldAbortOn(record)) {
                             log.info("Aborting transaction for record on topic {} as requested by connector", record.topic());
                             log.trace("Last record in aborted transaction: {}", record);
-                            abortTransaction();
+                            maybeAbortTransaction();

Review Comment:
   just curios. Is it possible that the transaction is closed and abortable records are existent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org