You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Brock Noland <br...@cloudera.com> on 2012/02/29 10:57:00 UTC
Review Request: FLUME-1009 HDFSEventSink should return BACKOFF when the
channel returns null
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4104/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
HDFSEventSink returns BACKOFF if the channel returns null. Added UNIT test to avoid regression.
This addresses bug FLUME-1009.
https://issues.apache.org/jira/browse/FLUME-1009
Diffs
-----
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 7d8ee8a
Diff: https://reviews.apache.org/r/4104/diff
Testing
-------
All unit tests pass.
Thanks,
Brock
Re: Review Request: FLUME-1009 HDFSEventSink should return BACKOFF when the
channel returns null
Posted by Juhani Connolly <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4104/#review5474
-----------------------------------------------------------
Ship it!
Simple and does the job it's expected to do!
- Juhani
On 2012-02-29 09:57:00, Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4104/
> -----------------------------------------------------------
>
> (Updated 2012-02-29 09:57:00)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> HDFSEventSink returns BACKOFF if the channel returns null. Added UNIT test to avoid regression.
>
>
> This addresses bug FLUME-1009.
> https://issues.apache.org/jira/browse/FLUME-1009
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c
> flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 7d8ee8a
>
> Diff: https://reviews.apache.org/r/4104/diff
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Brock
>
>
Re: Review Request: FLUME-1009 HDFSEventSink should return BACKOFF when the
channel returns null
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4104/#review5834
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-02-29 09:57:00, Brock Noland wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4104/
> -----------------------------------------------------------
>
> (Updated 2012-02-29 09:57:00)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> HDFSEventSink returns BACKOFF if the channel returns null. Added UNIT test to avoid regression.
>
>
> This addresses bug FLUME-1009.
> https://issues.apache.org/jira/browse/FLUME-1009
>
>
> Diffs
> -----
>
> flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 524b69c
> flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java 7d8ee8a
>
> Diff: https://reviews.apache.org/r/4104/diff
>
>
> Testing
> -------
>
> All unit tests pass.
>
>
> Thanks,
>
> Brock
>
>