[jira] [Commented] (HBASE-7615) Add metrics for snapshots

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13597227#comment-13597227 ] 

Ted Yu commented on HBASE-7615:
-------------------------------

I thought stats would be surfaced through metrics2.
{code}
+      return ((float)hfileSize / (hfileSize + hfileArchiveSize)) * 100;
{code}
Do we need to check that hfileSize + hfileArchiveSize != 0 ?


                
> Add metrics for snapshots
> -------------------------
>
>                 Key: HBASE-7615
>                 URL: https://issues.apache.org/jira/browse/HBASE-7615
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Matteo Bertozzi
>         Attachments: HBASE-7615-v0.patch, HBASE-7615-v0-ui-corrupted.png, HBASE-7615-v0-ui.png
>
>
> Metrics should be added for snapshot.
> From Matteo: Output that we have in SnapshotInfo should be covered:
> "%d HFiles (%d in archive), total size %s (%.2f%% %s shared with the source table)"
> Jesse mentioned snaphot counts, average time to completion.
> I think we should have counts for successful / failed snapshots.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira