You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/11/08 14:39:37 UTC
[PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
weizhouapache opened a new pull request, #8198:
URL: https://github.com/apache/cloudstack/pull/8198
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1802175860
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1802050272
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1804838649
<b>[SF] Trillian test result (tid-8283)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50905 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8198-t8283-kvm-centos7.zip
Smoke tests completed. 108 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3622.99 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3610.74 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 46.09 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 101.52 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1802207796
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8198?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#8198](https://app.codecov.io/gh/apache/cloudstack/pull/8198?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a232f85) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/11b5831d72643d88d5e12253b1770eae6353b9aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (11b5831) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.18 #8198 +/- ##
============================================
- Coverage 13.10% 13.09% -0.01%
- Complexity 9121 9122 +1
============================================
Files 2720 2720
Lines 257599 257599
Branches 40158 40158
============================================
- Hits 33747 33740 -7
- Misses 219588 219596 +8
+ Partials 4264 4263 -1
```
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/8198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1805379744
@weizhouapache I tested the PR, it didn't fix #8055 . Without these changes, it took roughly 10 minutes to restart a VPC with cleanup in an empty test environment. After applying the changes, the same VPC still required around 10 minutes for the restart.
Also tested VM deployments and ACL assignments they worked fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1802046676
@soreana @kriegsmanj can you test this ?
this probably fixes #8055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1802047492
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1802266706
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1803400813
@DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1804859841
<b>[SF] Trillian test result (tid-8282)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 52612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8198-t8282-vmware-67u3.zip
Smoke tests completed. 106 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_ping_in_ssvm_success | `Error` | 1.12 | test_diagnostics.py
test_04_ping_in_ssvm_failure | `Error` | 1.12 | test_diagnostics.py
test_08_arping_in_ssvm | `Error` | 1.12 | test_diagnostics.py
test_09_arping_in_cpvm | `Error` | 1.12 | test_diagnostics.py
test_11_traceroute_in_ssvm | `Error` | 1.12 | test_diagnostics.py
test_15_retrieve_ssvm_default_files | `Error` | 2.66 | test_diagnostics.py
test_16_retrieve_ssvm_single_file | `Error` | 1.13 | test_diagnostics.py
test_01_add_primary_storage_disabled_host | `Error` | 35.65 | test_primary_storage.py
test_01_non_strict_host_anti_affinity | `Failure` | 144.32 | test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity | `Error` | 103.02 | test_nonstrict_affinity_group.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1805556347
> @weizhouapache I tested the PR, it didn't fix #8055 . Without these changes, it took roughly 10 minutes to restart a VPC with cleanup in an empty test environment. After applying the changes, the same VPC still required around 10 minutes for the restart.
>
> Also tested VM deployments and ACL assignments they worked fine.
thanks @soreana
that's not good to know ;-D let's discuss in the issue #8055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1884336677
closing as it did not help https://github.com/apache/cloudstack/issues/8055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache closed pull request #8198: pom.xml: upgrade trilead-ssh2 verison
URL: https://github.com/apache/cloudstack/pull/8198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1803396699
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache closed pull request #8198: pom.xml: upgrade trilead-ssh2 verison
URL: https://github.com/apache/cloudstack/pull/8198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1802070477
> @soreana @kriegsmanj can you test this ? this probably fixes #8055
@weizhouapache I'm checking that. Thanks 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] pom.xml: upgrade trilead-ssh2 verison [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8198:
URL: https://github.com/apache/cloudstack/pull/8198#issuecomment-1805679412
Do we think this should be merged anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org