You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/03/25 18:13:43 UTC

[GitHub] [beam] jkff commented on pull request #14338: [BEAM-12044] JdbcIO read: always force autocommit to false

jkff commented on pull request #14338:
URL: https://github.com/apache/beam/pull/14338#issuecomment-807215759


   Actually this change might be mildly problematic for some users:
   
   Imagine a user who was loading a moderately large dataset from Postgres, but the dataset was fitting in memory.
   Now with this change the dataset will be streamed incrementally in batches of fetchSize, which will use less memory but more database roundtrips, so it might perform worse. It might be OK though, because the default fetch size is pretty large (50K). The problem will happen only if the user was setting a small fetch size, which previously wasn't having any effect. In that case, they'll need to set a larger fetchSize.
   
   Now that I think of it, this probably is not a problem, but thought worth mentioning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org