You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/13 21:54:16 UTC
[GitHub] [spark] rmcyang commented on a diff in pull request #38959: SPARK-41415: SASL Request Retries
rmcyang commented on code in PR #38959:
URL: https://github.com/apache/spark/pull/38959#discussion_r1070099546
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java:
##########
@@ -192,8 +200,14 @@ private synchronized void initiateRetry() {
private synchronized boolean shouldRetry(Throwable e) {
Review Comment:
Should the doc above be updated? Since we will also retry for SaslTimeoutException.
##########
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/RetryingBlockTransferorSuite.java:
##########
@@ -20,13 +20,18 @@
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.util.ArrayList;
import java.util.Arrays;
+import java.util.HashMap;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Map;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Sets;
+import java.util.concurrent.TimeoutException;
Review Comment:
nit: move this import statement to above group
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org