You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2023/04/10 17:04:19 UTC

Review Request 74388: ATLAS-4743: Remove unused libraries from build package.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74388/
-----------------------------------------------------------

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4743
    https://issues.apache.org/jira/browse/ATLAS-4743


Repository: atlas


Description
-------

Unused libraries were present in the final build package for UI.
for example: jquery-asBreadcrumbs


Diffs
-----

  dashboardv2/gruntfile.js fa79a1572 
  dashboardv2/package-lock.json 3bb11b483 
  dashboardv2/package.json 424304f11 
  dashboardv2/public/js/main.js 87d11ac72 
  dashboardv2/public/js/migration.js d6ed6875a 
  dashboardv2/public/js/utils/Overrides.js 492785aab 
  dashboardv3/gruntfile.js 37e4b32e7 
  dashboardv3/package-lock.json 881ea1ab8 
  dashboardv3/package.json a2cec26e8 
  dashboardv3/public/js/main.js 9fdd73ea3 
  dashboardv3/public/js/migration.js abb748f42 
  dashboardv3/public/js/utils/Overrides.js 492785aab 


Diff: https://reviews.apache.org/r/74388/diff/1/


Testing
-------

Manually tested for all the possible scenarios.


Thanks,

Farhan Khan


Re: Review Request 74388: ATLAS-4743: Remove unused libraries from build package.

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74388/#review225360
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On April 10, 2023, 5:17 p.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74388/
> -----------------------------------------------------------
> 
> (Updated April 10, 2023, 5:17 p.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4743
>     https://issues.apache.org/jira/browse/ATLAS-4743
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Unused libraries were present in the final build package for UI.
> for example: jquery-asBreadcrumbs
> 
> 
> Diffs
> -----
> 
>   dashboardv2/gruntfile.js fa79a1572 
>   dashboardv2/package-lock.json 3bb11b483 
>   dashboardv2/package.json 424304f11 
>   dashboardv2/public/index.html.tpl f678fd9b3 
>   dashboardv2/public/js/main.js 87d11ac72 
>   dashboardv2/public/js/migration.js d6ed6875a 
>   dashboardv2/public/js/utils/Overrides.js 492785aab 
>   dashboardv3/gruntfile.js 37e4b32e7 
>   dashboardv3/package-lock.json 881ea1ab8 
>   dashboardv3/package.json a2cec26e8 
>   dashboardv3/public/index.html.tpl 8b1e219e5 
>   dashboardv3/public/js/main.js 9fdd73ea3 
>   dashboardv3/public/js/migration.js abb748f42 
>   dashboardv3/public/js/utils/Overrides.js 492785aab 
> 
> 
> Diff: https://reviews.apache.org/r/74388/diff/2/
> 
> 
> Testing
> -------
> 
> Manually tested for all the possible scenarios.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>


Re: Review Request 74388: ATLAS-4743: Remove unused libraries from build package.

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74388/
-----------------------------------------------------------

(Updated April 10, 2023, 5:17 p.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4743
    https://issues.apache.org/jira/browse/ATLAS-4743


Repository: atlas


Description
-------

Unused libraries were present in the final build package for UI.
for example: jquery-asBreadcrumbs


Diffs (updated)
-----

  dashboardv2/gruntfile.js fa79a1572 
  dashboardv2/package-lock.json 3bb11b483 
  dashboardv2/package.json 424304f11 
  dashboardv2/public/index.html.tpl f678fd9b3 
  dashboardv2/public/js/main.js 87d11ac72 
  dashboardv2/public/js/migration.js d6ed6875a 
  dashboardv2/public/js/utils/Overrides.js 492785aab 
  dashboardv3/gruntfile.js 37e4b32e7 
  dashboardv3/package-lock.json 881ea1ab8 
  dashboardv3/package.json a2cec26e8 
  dashboardv3/public/index.html.tpl 8b1e219e5 
  dashboardv3/public/js/main.js 9fdd73ea3 
  dashboardv3/public/js/migration.js abb748f42 
  dashboardv3/public/js/utils/Overrides.js 492785aab 


Diff: https://reviews.apache.org/r/74388/diff/2/

Changes: https://reviews.apache.org/r/74388/diff/1-2/


Testing
-------

Manually tested for all the possible scenarios.


Thanks,

Farhan Khan