[GitHub] sergey-chugunov-1985 commented on a change in pull request #5781: IGNITE-10776 Migrate from JUnit 3 to 4 config variations test suites

[GitBox <gi...@apache.org>]

sergey-chugunov-1985 commented on a change in pull request #5781: IGNITE-10776 Migrate from JUnit 3 to 4 config variations test suites
URL: https://github.com/apache/ignite/pull/5781#discussion_r250173787
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCacheReadThroughEvictionsVariationsSuite.java
 ##########
 @@ -17,26 +17,21 @@
 
 package org.apache.ignite.internal.processors.cache;
 
-import junit.framework.TestSuite;
+import java.util.List;
 import org.apache.ignite.configuration.IgniteConfiguration;
 import org.apache.ignite.internal.binary.BinaryMarshaller;
 import org.apache.ignite.lang.IgnitePredicate;
 import org.apache.ignite.testframework.configvariations.ConfigVariationsTestSuiteBuilder;
 import org.junit.runner.RunWith;
-import org.junit.runners.AllTests;
+import org.junit.runners.Suite;
+import org.junit.runners.model.InitializationError;
 
-/**
- *
- */
-@RunWith(AllTests.class)
+/** */
+@RunWith(IgniteCacheReadThroughEvictionsVariationsSuite.DynamicSuite.class)
 public class IgniteCacheReadThroughEvictionsVariationsSuite {
 
 Review comment:
   It seems logical to move this test to the testsuites package where other suite classes reside.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services