[GitHub] [libcloud] c-w commented on a change in pull request #1332: [GH-1322] Detect broken `yum install python-requests`

[GitBox <gi...@apache.org>]

c-w commented on a change in pull request #1332: [GH-1322] Detect broken `yum install python-requests`
URL: https://github.com/apache/libcloud/pull/1332#discussion_r312765459
 
 

 ##########
 File path: libcloud/__init__.py
 ##########
 @@ -24,6 +24,8 @@
 import codecs
 import atexit
 
+import requests
 
 Review comment:
   In order to simplify the check and to stick with the existing pattern used for the paramiko library, I've changed the code to use a try/catch import. During `setup.py`, we don't particularly care about executing the requests version check (this can be delayed until first run of the library) so the functionality should be equivalent to what was there before. Let me know if this is okay.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services