You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/04/26 04:33:13 UTC

[GitHub] [incubator-brpc] yanglimingcn commented on a diff in pull request #1751: butex_wake_all support nosched flag

yanglimingcn commented on code in PR #1751:
URL: https://github.com/apache/incubator-brpc/pull/1751#discussion_r858258186


##########
src/bthread/butex.cpp:
##########
@@ -284,15 +286,19 @@ int butex_wake(void* arg, bool nosched) {
         if (!nosched) {
             TaskGroup::exchange(&g, bbw->tid);

Review Comment:
   exchange是希望调度的，所以应该是默认signal的，此外exchange也没有nosignal的参数



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org