[jira] [Commented] (TEXT-16) Improve HumanNameParser

["Benedikt Ritter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEXT-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14525121#comment-14525121 ] 

Benedikt Ritter commented on TEXT-16:
-------------------------------------

Looks promising to me. However we should try to make the ParseOptions immutable. This can be achieved by using {{Collections.unmodifiableSet}} in the getters. Further more it would be good to have an API where users can:
* Create a new Parser instance based on the configuration of another one. The use case for this is when you want to use the default options but with an additional suffix
* Create a new Parser from scratch

> Improve HumanNameParser
> -----------------------
>
>                 Key: TEXT-16
>                 URL: https://issues.apache.org/jira/browse/TEXT-16
>             Project: Commons Text
>          Issue Type: Improvement
>            Reporter: Bruno P. Kinoshita
>            Assignee: Benedikt Ritter
>            Priority: Minor
>              Labels: Refactoring
>
> From http://markmail.org/thread/da7ayocit2dl4otv
> - The constructor of the parser takes configuration options which can be
> reused for several names to parse
> - the parse method takes a string as parameter, containing a name
> - the parse method returns an immutable Name objects which has getters for
> firstName, lastName etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)