You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ap...@apache.org on 2019/05/16 15:28:32 UTC
[arrow] branch master updated: ARROW-5348: [Java][CI] Add missing
gandiva javadoc
This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 6c63c79 ARROW-5348: [Java][CI] Add missing gandiva javadoc
6c63c79 is described below
commit 6c63c7959772756e292ab8b82b5ddaa55a32411e
Author: Micah Kornfield <em...@gmail.com>
AuthorDate: Thu May 16 17:28:21 2019 +0200
ARROW-5348: [Java][CI] Add missing gandiva javadoc
Author: Micah Kornfield <em...@gmail.com>
Closes #4327 from emkornfield/ARROW-5348 and squashes the following commits:
67198f882 <Micah Kornfield> copy selection vector comment
4342fd159 <Micah Kornfield> ARROW-5348: Add missing gandiva javadoc
---
.../java/org/apache/arrow/gandiva/evaluator/DecimalTypeUtil.java | 5 +++--
.../main/java/org/apache/arrow/gandiva/evaluator/Projector.java | 7 +++++++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/DecimalTypeUtil.java b/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/DecimalTypeUtil.java
index 37dd0f6..0a05279 100644
--- a/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/DecimalTypeUtil.java
+++ b/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/DecimalTypeUtil.java
@@ -17,8 +17,6 @@
package org.apache.arrow.gandiva.evaluator;
-import org.apache.arrow.vector.types.Types;
-import org.apache.arrow.vector.types.pojo.ArrowType;
import org.apache.arrow.vector.types.pojo.ArrowType.Decimal;
public class DecimalTypeUtil {
@@ -35,6 +33,9 @@ public class DecimalTypeUtil {
/// The maximum precision representable by a 16-byte decimal
private static final int MAX_PRECISION = 38;
+ /**
+ * Determines the scale and precision of applying the given operation to the operands.
+ */
public static Decimal getResultTypeForOperation(OperationType operation, Decimal operand1, Decimal
operand2) {
int s1 = operand1.getScale();
diff --git a/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/Projector.java b/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/Projector.java
index fb7c6e4..96f8896 100644
--- a/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/Projector.java
+++ b/java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/Projector.java
@@ -142,6 +142,13 @@ public class Projector {
numRows, 0, 0, outColumns);
}
+ /**
+ * Invoke this function to evaluate a set of expressions against a {@link ArrowRecordBatch}.
+ *
+ * @param recordBatch The data to evaluate against.
+ * @param selectionVector Selection vector which stores the selected rows.
+ * @param outColumns Result of applying the project on the data
+ */
public void evaluate(ArrowRecordBatch recordBatch,
SelectionVector selectionVector, List<ValueVector> outColumns)
throws GandivaException {