[GitHub] [kafka] dajac commented on a change in pull request #8909: KAFKA-6733: Support of printing additional ConsumerRecord fields in DefaultMessageFormatter (rebased)

[GitBox <gi...@apache.org>]

dajac commented on a change in pull request #8909:
URL: https://github.com/apache/kafka/pull/8909#discussion_r449546534



##########
File path: core/src/main/scala/kafka/tools/ConsoleConsumer.scala
##########
@@ -460,46 +466,31 @@ class DefaultMessageFormatter extends MessageFormatter {
   var printKey = false
   var printValue = true
   var printPartition = false
-  var keySeparator = "\t".getBytes(StandardCharsets.UTF_8)
-  var lineSeparator = "\n".getBytes(StandardCharsets.UTF_8)
+  var printOffset = false
+  var printHeaders = false
+  var keySeparator = utfBytes("\t")
+  var lineSeparator = utfBytes("\n")
+  var headersSeparator = utfBytes(",")
 
   var keyDeserializer: Option[Deserializer[_]] = None
   var valueDeserializer: Option[Deserializer[_]] = None
+  var headersDeserializer: Option[Deserializer[_]] = None
 
   override def init(props: Properties): Unit = {

Review comment:
       @badaiaqrandista FYI, the `init` method has been deprecated as part of KIP-597: https://github.com/apache/kafka/pull/8604. You will have to adapt your PR to support it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org