[GitHub] morningman commented on a change in pull request #313: scheduler routine load job for stream load

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #313: scheduler routine load job for stream load
URL: https://github.com/apache/incubator-doris/pull/313#discussion_r233688791
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/persist/EditLog.java
 ##########
 @@ -776,14 +777,36 @@ public void logLoadDone(LoadJob job) {
         logEdit(OperationType.OP_LOAD_DONE, job);
     }
 
+    public void logRoutineLoadByState(RoutineLoadJob job, RoutineLoadJob.JobState jobState) {
+        switch (jobState) {
+            case NEED_SCHEDULER:
+                logEdit(OperationType.OP_ROUTINE_LOAD_NEED_SCHEDULER, job);
 
 Review comment:
   I think you should put JobState inside the RoutineLoadJob, and only use ONE OperationType to log the job.
   like: 
   
   logRoutineLoadJob(job) {
       logEdit(OperationType.OP_ROUTINE_LOAD_JOB, job)
   }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org