You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2023/03/07 00:21:05 UTC
[GitHub] [druid] gianm opened a new pull request, #13888: Add warning comments to Granularity.getIterable.
gianm opened a new pull request, #13888:
URL: https://github.com/apache/druid/pull/13888
This function is notorious for causing memory exhaustion and excessive CPU usage; so much so that it was valuable to work around it in the SQL planner in #13206. Hopefully, a warning comment will encourage developers to stay away and come up with solutions that do not involve computing all possible buckets.
More recently, #13706 introduced some new logic that uses this problematic method, which causes certain `REPLACE` statements to run out of memory materializing large numbers of buckets. This will need to be fixed separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #13888: Add warning comments to Granularity.getIterable.
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm merged PR #13888:
URL: https://github.com/apache/druid/pull/13888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #13888: Add warning comments to Granularity.getIterable.
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #13888:
URL: https://github.com/apache/druid/pull/13888#issuecomment-1457639886
Ignoring the failed IT; this patch only adjusts comments so it wouldn't be related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org