You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2012/05/19 01:13:06 UTC

[jira] [Created] (SLING-2489) Updating the framework with system bundle update fails

Felix Meschberger created SLING-2489:
----------------------------------------

             Summary: Updating the framework with system bundle update fails
                 Key: SLING-2489
                 URL: https://issues.apache.org/jira/browse/SLING-2489
             Project: Sling
          Issue Type: Bug
          Components: Launchpad
    Affects Versions: Launchpad Base 2.4.0
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger
             Fix For: Launchpad Base 2.4.2


The Main.Notified.updated(File) method first calls Main.stopSling to properly stop and cleanup after sling's shutdown and the calls Main.startSling to install the new framework and launch it.

The problem is that stopSling sets the launcher field to null and thus startSling assuming the launcher field to not be null to fail with a NullPointerException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (SLING-2489) Updating the framework with system bundle update fails

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-2489.
--------------------------------------

    Resolution: Fixed

Reverted the change to static method in Rev. 1366880 (plus added a note on why the method is declared like this)
                
> Updating the framework with system bundle update fails
> ------------------------------------------------------
>
>                 Key: SLING-2489
>                 URL: https://issues.apache.org/jira/browse/SLING-2489
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad
>    Affects Versions: Launchpad Base 2.4.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Launchpad Base 2.4.2
>
>
> The Main.Notified.updated(File) method first calls Main.stopSling to properly stop and cleanup after sling's shutdown and the calls Main.startSling to install the new framework and launch it.
> The problem is that stopSling sets the launcher field to null and thus startSling assuming the launcher field to not be null to fail with a NullPointerException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (SLING-2489) Updating the framework with system bundle update fails

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reopened SLING-2489:
--------------------------------------


Urks, sorry for that.

Thanks for reporting.
                
> Updating the framework with system bundle update fails
> ------------------------------------------------------
>
>                 Key: SLING-2489
>                 URL: https://issues.apache.org/jira/browse/SLING-2489
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad
>    Affects Versions: Launchpad Base 2.4.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Launchpad Base 2.4.2
>
>
> The Main.Notified.updated(File) method first calls Main.stopSling to properly stop and cleanup after sling's shutdown and the calls Main.startSling to install the new framework and launch it.
> The problem is that stopSling sets the launcher field to null and thus startSling assuming the launcher field to not be null to fail with a NullPointerException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (SLING-2489) Updating the framework with system bundle update fails

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-2489.
--------------------------------------

    Resolution: Fixed

Refactor start/stop logic such that doStart(URL) and doStop() are completely symmetric and can be used to repeatedly start/stop the framework in Rev. 1366559:
  - Add proper shutdown hook handling
  - Heuristically cleanup threads remaining after framework stop

Thread cleanup is currently extremely heuristically based. This cleanup (particuarly the FileCleaningTracker$Reaper thread of the Commons IO library) has to be investigated.

Considering this issue done for now.
                
> Updating the framework with system bundle update fails
> ------------------------------------------------------
>
>                 Key: SLING-2489
>                 URL: https://issues.apache.org/jira/browse/SLING-2489
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad
>    Affects Versions: Launchpad Base 2.4.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Launchpad Base 2.4.2
>
>
> The Main.Notified.updated(File) method first calls Main.stopSling to properly stop and cleanup after sling's shutdown and the calls Main.startSling to install the new framework and launch it.
> The problem is that stopSling sets the launcher field to null and thus startSling assuming the launcher field to not be null to fail with a NullPointerException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (SLING-2489) Updating the framework with system bundle update fails

Posted by "Pontus Amberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424239#comment-13424239 ] 

Pontus Amberg commented on SLING-2489:
--------------------------------------

Since terminateVM in org.apache.sling.launchpad.app.Main is static now org.apache.sling.launchpad.app.ControlListenerTest.MyMain will not compile.
                
> Updating the framework with system bundle update fails
> ------------------------------------------------------
>
>                 Key: SLING-2489
>                 URL: https://issues.apache.org/jira/browse/SLING-2489
>             Project: Sling
>          Issue Type: Bug
>          Components: Launchpad
>    Affects Versions: Launchpad Base 2.4.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Launchpad Base 2.4.2
>
>
> The Main.Notified.updated(File) method first calls Main.stopSling to properly stop and cleanup after sling's shutdown and the calls Main.startSling to install the new framework and launch it.
> The problem is that stopSling sets the launcher field to null and thus startSling assuming the launcher field to not be null to fail with a NullPointerException

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira