You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/16 08:24:32 UTC

[GitHub] [mynewt-mcumgr] greg-leach commented on a change in pull request #112: Bug #18312 Add support for half-floats to MCUMGR

greg-leach commented on a change in pull request #112:
URL: https://github.com/apache/mynewt-mcumgr/pull/112#discussion_r576629119



##########
File path: cborattr/include/cborattr/cborattr.h
##########
@@ -85,6 +86,9 @@ struct cbor_array_t {
         struct {
             double *store;
         } reals;
+        struct{
+            int *store;
+        } halffloats;

Review comment:
       The thinking here was to use standard C types, looking further on in the code I can see uint16_t being used. I've updated the halffloat to be a uint16_t type.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org