You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/11 20:15:21 UTC
[GitHub] [iceberg] kbendick opened a new pull request, #5252: BUILD - Fix gradle execution optimizations being disabled for iceberg-api:processTestResources
kbendick opened a new pull request, #5252:
URL: https://github.com/apache/iceberg/pull/5252
When running iceberg-api gradle test tasks on master, a warning is printed that execution optimizations are disabled for `iceberg-api:processTestResources`.
This is because of an undeclared implicit dependency between `generateGitResources` and `iceberg-api:processTestResources`. This occurs despite an explicit dependency between `iceberg-api:test` and `:buildInfo`.
When running `./gradlew clean :iceberg-api:check -x test` the following warning is printed.
```bash
> Task :iceberg-api:processTestResources
Execution optimizations have been disabled for task ':iceberg-api:processTestResources' to ensure correctness due to the following reasons:
- Gradle detected a problem with the following location: '/Users/kylebendickson/repos/iceberg/build'. Reason: Task ':iceberg-api:processTestResources' uses this output of task ':generateGitProperties' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.4.2/userguide/validation_problems.html#implicit_dependency for more details about this problem.
```
This patch removes that warning.
cc @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5252: BUILD - Fix gradle execution optimizations being disabled for iceberg-api:processTestResources
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5252:
URL: https://github.com/apache/iceberg/pull/5252#discussion_r918422618
##########
build.gradle:
##########
@@ -224,6 +224,7 @@ project(':iceberg-api') {
testImplementation "org.apache.avro:avro"
}
+ tasks.processTestResources.dependsOn rootProject.tasks.buildInfo
Review Comment:
Is the dependency on the next line still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5252: BUILD - Fix gradle execution optimizations being disabled for iceberg-api:processTestResources
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5252:
URL: https://github.com/apache/iceberg/pull/5252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a diff in pull request #5252: BUILD - Fix gradle execution optimizations being disabled for iceberg-api:processTestResources
Posted by GitBox <gi...@apache.org>.
kbendick commented on code in PR #5252:
URL: https://github.com/apache/iceberg/pull/5252#discussion_r918553590
##########
build.gradle:
##########
@@ -224,6 +224,7 @@ project(':iceberg-api') {
testImplementation "org.apache.avro:avro"
}
+ tasks.processTestResources.dependsOn rootProject.tasks.buildInfo
Review Comment:
No it’s not. Removed it
I checked for the warning, as well as ran build / test tasks with and without clean (and existing property file) and everything was as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org