You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/12/22 01:49:43 UTC
Re: GEODE-2243: Adjust path of spotless formatter
I'm seeing the same thing. I went ahead and reverted the change so our
build isn't broken.
-Dan
On Wed, Dec 21, 2016 at 4:49 PM, Mark Bretl <mb...@apache.org> wrote:
> Jens,
>
> Please revert this commit. I feel like the JIRA issue, GEODE-2243, was done
> with separate specific environment in mind and not done for the
> community. This does not work for standard Geode development environment...
>
> Unable to apply step Eclipse Formatter to src/main/java/org/apache/geode
> /rest/internal/web/util/ValidationUtils.java: Eclipse formatter file
> '/Users/mbretl/bldz/open/etc/eclipse-java-google-style.xml' does not
> exist.
>
> --Mark
> ---------- Forwarded message ----------
> From: <je...@apache.org>
> Date: Wed, Dec 21, 2016 at 2:53 PM
> Subject: geode git commit: GEODE-2243: Adjust path of spotless formatter
> To: commits@geode.apache.org
>
>
> Repository: geode
> Updated Branches:
> refs/heads/develop eba189bb1 -> c1998d739
>
>
> GEODE-2243: Adjust path of spotless formatter
>
> - This allows projects which depend on Geode to use Geode's formatter
>
> Signed-off-by: Scott Jewell <sj...@pivotal.io>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/geode/repo
> Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/c1998d73
> Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/c1998d73
> Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/c1998d73
>
> Branch: refs/heads/develop
> Commit: c1998d7398b837ee1e699bfd1952719443045d71
> Parents: eba189b
> Author: Jens Deppe <jd...@pivotal.io>
> Authored: Wed Dec 21 14:52:11 2016 -0800
> Committer: Jens Deppe <jd...@pivotal.io>
> Committed: Wed Dec 21 14:53:25 2016 -0800
>
> ----------------------------------------------------------------------
> build.gradle | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/geode/blob/c1998d73/build.gradle
> ----------------------------------------------------------------------
> diff --git a/build.gradle b/build.gradle
> index 360310f..d788250 100755
> --- a/build.gradle
> +++ b/build.gradle
> @@ -91,7 +91,7 @@ subprojects {
> spotless {
> lineEndings = 'unix';
> java {
> - eclipseFormatFile "${rootProject.projectDir}/etc
> /eclipse-java-google-style.xml"
> + eclipseFormatFile "${rootProject.projectDir}/../
> open/etc/eclipse-java-google-style.xml"
> }
> }
> }
>
Re: GEODE-2243: Adjust path of spotless formatter
Posted by Dan Smith <ds...@pivotal.io>.
Hi Scott,
The issue is that this line only works if your geode checkout is in a
folder called open:
eclipseFormatFile
"${rootProject.projectDir}/../open/etc/eclipse-java-google-style.xml"
That's not going to work for many people; the default name of the folder is
geode if you do git clone https://git-wip-us.apache.org/repos/asf/geode.git.
-Dan
On Wed, Dec 21, 2016 at 6:11 PM, Scott Jewell <sj...@pivotal.io> wrote:
> Hi Dan,
>
> Since the spotless stuff lives on the open side, you just need to make sure
> to pull a fresh copy of the open side in order for the closed side build to
> work.
>
> I suppose we could have left the redundant xml file in the closed branch
> for a
> while so that stale open branches would still allow the fresh closed side
> to build.
>
> Talk with ya later.
>
> On Wed, Dec 21, 2016 at 5:49 PM, Dan Smith <ds...@pivotal.io> wrote:
>
> > I'm seeing the same thing. I went ahead and reverted the change so our
> > build isn't broken.
> >
> > -Dan
> >
> > On Wed, Dec 21, 2016 at 4:49 PM, Mark Bretl <mb...@apache.org> wrote:
> >
> > > Jens,
> > >
> > > Please revert this commit. I feel like the JIRA issue, GEODE-2243, was
> > done
> > > with separate specific environment in mind and not done for the
> > > community. This does not work for standard Geode development
> > environment...
> > >
> > > Unable to apply step Eclipse Formatter to
> src/main/java/org/apache/geode
> > > /rest/internal/web/util/ValidationUtils.java: Eclipse formatter file
> > > '/Users/mbretl/bldz/open/etc/eclipse-java-google-style.xml' does not
> > > exist.
> > >
> > > --Mark
> > > ---------- Forwarded message ----------
> > > From: <je...@apache.org>
> > > Date: Wed, Dec 21, 2016 at 2:53 PM
> > > Subject: geode git commit: GEODE-2243: Adjust path of spotless
> formatter
> > > To: commits@geode.apache.org
> > >
> > >
> > > Repository: geode
> > > Updated Branches:
> > > refs/heads/develop eba189bb1 -> c1998d739
> > >
> > >
> > > GEODE-2243: Adjust path of spotless formatter
> > >
> > > - This allows projects which depend on Geode to use Geode's formatter
> > >
> > > Signed-off-by: Scott Jewell <sj...@pivotal.io>
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/geode/repo
> > > Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/c1998d73
> > > Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/c1998d73
> > > Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/c1998d73
> > >
> > > Branch: refs/heads/develop
> > > Commit: c1998d7398b837ee1e699bfd1952719443045d71
> > > Parents: eba189b
> > > Author: Jens Deppe <jd...@pivotal.io>
> > > Authored: Wed Dec 21 14:52:11 2016 -0800
> > > Committer: Jens Deppe <jd...@pivotal.io>
> > > Committed: Wed Dec 21 14:53:25 2016 -0800
> > >
> > > ----------------------------------------------------------------------
> > > build.gradle | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > ----------------------------------------------------------------------
> > >
> > >
> > > http://git-wip-us.apache.org/repos/asf/geode/blob/c1998d73/
> build.gradle
> > > ----------------------------------------------------------------------
> > > diff --git a/build.gradle b/build.gradle
> > > index 360310f..d788250 100755
> > > --- a/build.gradle
> > > +++ b/build.gradle
> > > @@ -91,7 +91,7 @@ subprojects {
> > > spotless {
> > > lineEndings = 'unix';
> > > java {
> > > - eclipseFormatFile "${rootProject.projectDir}/etc
> > > /eclipse-java-google-style.xml"
> > > + eclipseFormatFile "${rootProject.projectDir}/../
> > > open/etc/eclipse-java-google-style.xml"
> > > }
> > > }
> > > }
> > >
> >
>
>
>
> --
> Scott Jewell
> sjewell@pivotal.io
>
Re: GEODE-2243: Adjust path of spotless formatter
Posted by Scott Jewell <sj...@pivotal.io>.
Hi Dan,
Since the spotless stuff lives on the open side, you just need to make sure
to pull a fresh copy of the open side in order for the closed side build to
work.
I suppose we could have left the redundant xml file in the closed branch
for a
while so that stale open branches would still allow the fresh closed side
to build.
Talk with ya later.
On Wed, Dec 21, 2016 at 5:49 PM, Dan Smith <ds...@pivotal.io> wrote:
> I'm seeing the same thing. I went ahead and reverted the change so our
> build isn't broken.
>
> -Dan
>
> On Wed, Dec 21, 2016 at 4:49 PM, Mark Bretl <mb...@apache.org> wrote:
>
> > Jens,
> >
> > Please revert this commit. I feel like the JIRA issue, GEODE-2243, was
> done
> > with separate specific environment in mind and not done for the
> > community. This does not work for standard Geode development
> environment...
> >
> > Unable to apply step Eclipse Formatter to src/main/java/org/apache/geode
> > /rest/internal/web/util/ValidationUtils.java: Eclipse formatter file
> > '/Users/mbretl/bldz/open/etc/eclipse-java-google-style.xml' does not
> > exist.
> >
> > --Mark
> > ---------- Forwarded message ----------
> > From: <je...@apache.org>
> > Date: Wed, Dec 21, 2016 at 2:53 PM
> > Subject: geode git commit: GEODE-2243: Adjust path of spotless formatter
> > To: commits@geode.apache.org
> >
> >
> > Repository: geode
> > Updated Branches:
> > refs/heads/develop eba189bb1 -> c1998d739
> >
> >
> > GEODE-2243: Adjust path of spotless formatter
> >
> > - This allows projects which depend on Geode to use Geode's formatter
> >
> > Signed-off-by: Scott Jewell <sj...@pivotal.io>
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/geode/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/c1998d73
> > Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/c1998d73
> > Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/c1998d73
> >
> > Branch: refs/heads/develop
> > Commit: c1998d7398b837ee1e699bfd1952719443045d71
> > Parents: eba189b
> > Author: Jens Deppe <jd...@pivotal.io>
> > Authored: Wed Dec 21 14:52:11 2016 -0800
> > Committer: Jens Deppe <jd...@pivotal.io>
> > Committed: Wed Dec 21 14:53:25 2016 -0800
> >
> > ----------------------------------------------------------------------
> > build.gradle | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> > http://git-wip-us.apache.org/repos/asf/geode/blob/c1998d73/build.gradle
> > ----------------------------------------------------------------------
> > diff --git a/build.gradle b/build.gradle
> > index 360310f..d788250 100755
> > --- a/build.gradle
> > +++ b/build.gradle
> > @@ -91,7 +91,7 @@ subprojects {
> > spotless {
> > lineEndings = 'unix';
> > java {
> > - eclipseFormatFile "${rootProject.projectDir}/etc
> > /eclipse-java-google-style.xml"
> > + eclipseFormatFile "${rootProject.projectDir}/../
> > open/etc/eclipse-java-google-style.xml"
> > }
> > }
> > }
> >
>
--
Scott Jewell
sjewell@pivotal.io