[GitHub] [hadoop] goiri commented on a change in pull request #1699: HDFS-14962. RBF: ConnectionPool#newConnection() error log wrong protocol class

[GitBox <gi...@apache.org>]

goiri commented on a change in pull request #1699: HDFS-14962. RBF: ConnectionPool#newConnection() error log wrong protocol class
URL: https://github.com/apache/hadoop/pull/1699#discussion_r343822488
 
 

 ##########
 File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionPool.java
 ##########
 @@ -374,7 +374,7 @@ public ConnectionContext newConnection() throws IOException {
       throws IOException {
     if (!PROTO_MAP.containsKey(proto)) {
       String msg = "Unsupported protocol for connection to NameNode: "
-          + ((proto != null) ? proto.getClass().getName() : "null");
+          + ((proto != null) ? proto.getName() : "null");
 
 Review comment:
   Let's add a unit test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org