You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mproch <gi...@git.apache.org> on 2016/09/14 21:26:38 UTC
[GitHub] flink pull request #2498: [FLINK-4619] - JobManager does not answer to clien...
GitHub user mproch opened a pull request:
https://github.com/apache/flink/pull/2498
[FLINK-4619] - JobManager does not answer to client when restore from savepoint fails
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mproch/flink flink-4619
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2498.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2498
----
commit 79ed80af927ecededd06ba61d98879b189f064ea
Author: Maciek Pr�chniak <mp...@touk.pl>
Date: 2016-09-14T12:27:27Z
[FLINK-4619] - JobManager does not answer to client when restore from savepoint fails
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2498: [FLINK-4619] - JobManager does not answer to client when ...
Posted by mproch <gi...@git.apache.org>.
Github user mproch commented on the issue:
https://github.com/apache/flink/pull/2498
Hmm... I managed to make travis build pass, but I cannot see how jenkins test failures relate to my change...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2498: [FLINK-4619] - JobManager does not answer to client when ...
Posted by mproch <gi...@git.apache.org>.
Github user mproch commented on the issue:
https://github.com/apache/flink/pull/2498
Yes, it's a bit more tricky then I expected... These tests probably also need to be changed, because they relied on previous behaviour... What's more with the change some checks on FlinkMiniCluster start to be non-deterministic... I'll commit fixes when I'll fully understand how it works...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2498: [FLINK-4619] - JobManager does not answer to client when ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2498
No need to re-trigger this. Travis green light is good.
@uce - Do you think this works well with your latest changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2498: [FLINK-4619] - JobManager does not answer to client when ...
Posted by mproch <gi...@git.apache.org>.
Github user mproch commented on the issue:
https://github.com/apache/flink/pull/2498
@StephanEwen can I retrigger this or whatever?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2498: [FLINK-4619] - JobManager does not answer to client when ...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2498
Yes, I merge this later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2498: [FLINK-4619] - JobManager does not answer to clien...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2498
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2498: [FLINK-4619] - JobManager does not answer to client when ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2498
Good idea. Unfortunately, the changed broke some tests:
- `SavepointITCase.testSubmitWithUnknownSavepointPath`
- `RescalingITCase.testSavepointRescalingFailureWithNonPartitionedState`
You can see more in the Travis CI report.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---