You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Manikumar Reddy O <ma...@gmail.com> on 2014/07/09 18:07:59 UTC

Review Request 23363: Patch for KAFKA-1325

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23363/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1325
    https://issues.apache.org/jira/browse/KAFKA-1325


Repository: kafka


Description
-------

Added log.retention.ms and log.roll.ms in the server config. If both log.retention.ms and log.retention.minutes are given then log.retention.ms will be given priority. If both log.roll.ms and log.roll.hours are given then
log.roll.ms property will be given prioroty.


Diffs
-----

  core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3 
  core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba 
  core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala 6f4809da9968de293f365307ffd9cfe1d5c34ce0 

Diff: https://reviews.apache.org/r/23363/diff/


Testing
-------


Thanks,

Manikumar Reddy O