You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/25 23:25:16 UTC
[GitHub] [arrow] mqy opened a new pull request #9013: ARROW-11034: [Rust]: remove rustfmt ignore list, fix format
mqy opened a new pull request #9013:
URL: https://github.com/apache/arrow/pull/9013
In this PR:
- Ignore list is commented out from rustfmt.toml, thus `carrgo fmt +stable` would not show warnings
- Two files are re-formatted by nightly, stable: this may avoid formatting problem we had seen in CI (hope so).
Shell commands that I had run:
```
cargo +nightly-2020-11-24-x86_64 fmt
cargo +1.48.0-x86_64 fmt
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9013: ARROW-11034: [Rust] remove rustfmt ignore list, fix format
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9013:
URL: https://github.com/apache/arrow/pull/9013#issuecomment-751300429
https://issues.apache.org/jira/browse/ARROW-11034
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9013: ARROW-11034: [Rust] remove rustfmt ignore list, fix format
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9013:
URL: https://github.com/apache/arrow/pull/9013#issuecomment-751300201
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9013?src=pr&el=h1) Report
> Merging [#9013](https://codecov.io/gh/apache/arrow/pull/9013?src=pr&el=desc) (4e40312) into [master](https://codecov.io/gh/apache/arrow/commit/a4f7c4a2acda874b3d6eb2eb4c986e7c3267c755?el=desc) (a4f7c4a) will **decrease** coverage by `0.00%`.
> The diff coverage is `68.42%`.
[](https://codecov.io/gh/apache/arrow/pull/9013?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9013 +/- ##
==========================================
- Coverage 82.87% 82.87% -0.01%
==========================================
Files 201 201
Lines 49739 49743 +4
==========================================
+ Hits 41220 41223 +3
- Misses 8519 8520 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9013?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/parquet/src/record/api.rs](https://codecov.io/gh/apache/arrow/pull/9013/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9yZWNvcmQvYXBpLnJz) | `97.88% <66.66%> (-0.13%)` | :arrow_down: |
| [rust/datafusion/src/scalar.rs](https://codecov.io/gh/apache/arrow/pull/9013/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zY2FsYXIucnM=) | `59.07% <68.75%> (-0.08%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9013/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9013?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9013?src=pr&el=footer). Last update [a4f7c4a...4e40312](https://codecov.io/gh/apache/arrow/pull/9013?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9013: ARROW-11034: [Rust] remove rustfmt ignore list, fix format
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9013:
URL: https://github.com/apache/arrow/pull/9013#issuecomment-751463000
Thanks @mqy !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9013: ARROW-11034: [Rust] remove rustfmt ignore list, fix format
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9013:
URL: https://github.com/apache/arrow/pull/9013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org