Adding contributors to pom.xml

[Enrico Olivelli <eo...@gmail.com>]

Hi,
Is there any rule to add a reference to a contributor in the contributors
section of the pom.xml of a plugin.

For instance today I have merged a PR from a new time contributor to the
maven jdeps plugin.
Should I add his email/reference to the pom of that plugin?

I remember that the first time I contributed to the war plugin the
committer added me to the list of contributors to the project.
It was very exciting as a first time contribution for me.


Enrico

Re: Adding contributors to pom.xml

[Michael Osipov <mi...@apache.org>]

Am 2019-05-28 um 22:17 schrieb Enrico Olivelli:
> Hi,
> Is there any rule to add a reference to a contributor in the contributors
> section of the pom.xml of a plugin.
> 
> For instance today I have merged a PR from a new time contributor to the
> maven jdeps plugin.
> Should I add his email/reference to the pom of that plugin?
> 
> I remember that the first time I contributed to the war plugin the
> committer added me to the list of contributors to the project.
> It was very exciting as a first time contribution for me.

I have personally stopped doing this because

1) their names show up in the Git commit, in Subversion I have added a 
Submitted-by line. Credit is fully retained
2) I highly doubt that someone will ever read that page generated by MPIR

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

Re: Adding contributors to pom.xml

[Tibor Digana <ti...@apache.org>]

We should ask the contributor because some German companies do not allow
you to work in OSS unless you have got an internal confirmation from
commercial management.
My last company had this rule; does not matter if the prodution area is the
same with OSS or not.
In my case we were in totally different production field than Maven.
It is important for the user in this case much more.

On Tue, May 28, 2019 at 10:52 PM Robert Scholte <rf...@apache.org>
wrote:

> > It was very exciting as a first time contribution for me.
>
> This would indeed be a good reason to do so.
> With GDPR in mind it is probably better to ask the contributor to add its
> own name to the pom file.
>
> Robert
> On 28-5-2019 22:24:17, Enrico Olivelli <eo...@gmail.com> wrote:
> Hi,
> Is there any rule to add a reference to a contributor in the contributors
> section of the pom.xml of a plugin.
>
> For instance today I have merged a PR from a new time contributor to the
> maven jdeps plugin.
> Should I add his email/reference to the pom of that plugin?
>
> I remember that the first time I contributed to the war plugin the
> committer added me to the list of contributors to the project.
> It was very exciting as a first time contribution for me.
>
>
> Enrico
>

Re: Adding contributors to pom.xml

[Robert Scholte <rf...@apache.org>]

> It was very exciting as a first time contribution for me.

This would indeed be a good reason to do so. 
With GDPR in mind it is probably better to ask the contributor to add its own name to the pom file.

Robert
On 28-5-2019 22:24:17, Enrico Olivelli <eo...@gmail.com> wrote:
Hi,
Is there any rule to add a reference to a contributor in the contributors
section of the pom.xml of a plugin.

For instance today I have merged a PR from a new time contributor to the
maven jdeps plugin.
Should I add his email/reference to the pom of that plugin?

I remember that the first time I contributed to the war plugin the
committer added me to the list of contributors to the project.
It was very exciting as a first time contribution for me.


Enrico

Re: Adding contributors to pom.xml

[Tibor Digana <ti...@apache.org>]

Not sure there is a real limitation to do it.
We can at least see new candidates for committers from the group of
contributors.
The contributors like it of course, and why not, their work is valuable!

On Tue, May 28, 2019 at 10:24 PM Enrico Olivelli <eo...@gmail.com>
wrote:

> Hi,
> Is there any rule to add a reference to a contributor in the contributors
> section of the pom.xml of a plugin.
>
> For instance today I have merged a PR from a new time contributor to the
> maven jdeps plugin.
> Should I add his email/reference to the pom of that plugin?
>
> I remember that the first time I contributed to the war plugin the
> committer added me to the list of contributors to the project.
> It was very exciting as a first time contribution for me.
>
>
> Enrico
>