[GitHub] [airflow] ashb commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #4743: [AIRFLOW-3871] render Operators template fields recursively
URL: https://github.com/apache/airflow/pull/4743#discussion_r279769894
 
 

 ##########
 File path: airflow/models/baseoperator.py
 ##########
 @@ -644,9 +648,23 @@ def render_template_from_field(self, attr, content, context, jinja_env):
                 k: rt("{}[{}]".format(attr, k), v, context)
                 for k, v in list(content.items())}
         else:
-            result = content
+            result = self._render_nested_template_fields(content, context)
         return result
 
+    def _render_nested_template_fields(self, content, context):
 
 Review comment:
   Since _rendered_template_object_ids is only relevant to this function can we instead change the sig to:
   
   ```suggestion
       def _render_nested_template_fields(self, content, context, seen_oids):
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services