You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2013/04/17 16:07:16 UTC

[jira] [Commented] (JCR-3573) Improve token based login concurrency

    [ https://issues.apache.org/jira/browse/JCR-3573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634053#comment-13634053 ] 

angela commented on JCR-3573:
-----------------------------

looks a bit hacky, doesn't it? i would prefer to have but a single save during the login....
anyway.... since i decided choose a total different approach in oak which completely separates the token
handling out of the default login handling and jackrabbit-core will die soon anyway, i don't mind applying the patch if it this helps.
                
> Improve token based login concurrency
> -------------------------------------
>
>                 Key: JCR-3573
>                 URL: https://issues.apache.org/jira/browse/JCR-3573
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-3573.patch
>
>
> Currently TokenBasedAuthentication.createToken() is synchronized and therefore serializes creation of tokens repository wide.
> Removing the synchronization shows test failures because the .tokens node is created concurrently by multiple sessions. Instead of serializing the calls, we could also use an optimistic approach. See attached patch. All tests pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira