You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/29 22:05:08 UTC
[GitHub] [superset] etr2460 opened a new pull request #15959: fix: downgrade pivot-table because of breaking changes
etr2460 opened a new pull request #15959:
URL: https://github.com/apache/superset/pull/15959
### SUMMARY
I'm downgrading pivot-table back to version 0.17.67 because we have people using this visualization reporting breaking changes with conditional formatting from https://github.com/apache/superset/pull/15742 and superset-ui has been too active for me to fix forward in this case.
It seems as if there's still a lot of development on this visualization, however since it's not behind a feature flag we had people actively using it in production, and therefore need to prevent regressions here. I'm hoping that we can merge fixes into superset-ui and then upgrade back to a fully functional version that either migrates the old charts to use the new controls properly or fixes the regression. Thanks!
### TESTING INSTRUCTIONS
CI, use the test env
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @kgabryje @villebro
cc: @graceguo-supercat @serenajiang @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889491316
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889491661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] removed a comment on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889491674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 removed a comment on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
etr2460 removed a comment on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889491316
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889499019
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889500797
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889501618
@etr2460 Ephemeral environment spinning up at http://54.190.196.58:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889500157
# [Codecov](https://codecov.io/gh/apache/superset/pull/15959?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15959](https://codecov.io/gh/apache/superset/pull/15959?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9969148) into [master](https://codecov.io/gh/apache/superset/commit/3b9b2c97aa753552be8b8440054e6acd242ba13a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b9b2c9) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 9969148 differs from pull request most recent head 8725a81. Consider uploading reports for the commit 8725a81 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15959?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15959 +/- ##
=======================================
Coverage 76.99% 76.99%
=======================================
Files 988 988
Lines 52371 52371
Branches 6621 6621
=======================================
Hits 40324 40324
Misses 11824 11824
Partials 223 223
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.58% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15959?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15959?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3b9b2c9...8725a81](https://codecov.io/gh/apache/superset/pull/15959?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-891896548
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-891896223
closing since this didn't resolve the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 closed pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
etr2460 closed pull request #15959:
URL: https://github.com/apache/superset/pull/15959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15959: fix: downgrade pivot-table because of breaking changes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15959:
URL: https://github.com/apache/superset/pull/15959#issuecomment-889499273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org