[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #2675: ARTEMIS-2347 JournalStorageManager::stopReplication can deadlock while stopping
URL: https://github.com/apache/activemq-artemis/pull/2675#discussion_r286328434
 
 

 ##########
 File path: artemis-server/src/test/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManagerTest.java
 ##########
 @@ -145,4 +166,73 @@ public void testFixJournalFileSize() {
       Assert.assertEquals(4096, manager.fixJournalFileSize(4098, 4096));
       Assert.assertEquals(8192, manager.fixJournalFileSize(8192, 4096));
    }
+
+   @Test(timeout = 20_000)
 
 Review comment:
   :+1: Thanks to have taken a look bud, please check if now is ok (I don't have a Mac/Win to test it!)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services