You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2012/07/23 17:54:00 UTC
Review Request: QPID-4163: Deadlock between LinkRegistry and TimerTask locks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6092/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
Description
-------
TimerTask::cancel was being called with locks held, causing a deadlock.
See JIRA for stack trace.
Moved call to cancel() out of the lock.
Diffs
-----
/trunk/qpid/cpp/src/qpid/broker/Link.cpp 1363520
/trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1363520
Diff: https://reviews.apache.org/r/6092/diff/
Testing
-------
make check
Thanks,
Alan Conway
Re: Review Request: QPID-4163: Deadlock between LinkRegistry and TimerTask
locks
Posted by Andrew Stitcher <as...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6092/#review9358
-----------------------------------------------------------
Ship it!
These look good to me, but I'm not so familiar with the Link/LinkRegistry code.
- Andrew Stitcher
On July 23, 2012, 3:54 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6092/
> -----------------------------------------------------------
>
> (Updated July 23, 2012, 3:54 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
>
>
> Description
> -------
>
> TimerTask::cancel was being called with locks held, causing a deadlock.
> See JIRA for stack trace.
>
> Moved call to cancel() out of the lock.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1363520
> /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1363520
>
> Diff: https://reviews.apache.org/r/6092/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request: QPID-4163: Deadlock between LinkRegistry and TimerTask
locks
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6092/#review9359
-----------------------------------------------------------
Ship it!
Ship It!
- Gordon Sim
On July 23, 2012, 3:54 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6092/
> -----------------------------------------------------------
>
> (Updated July 23, 2012, 3:54 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Gordon Sim, and Ted Ross.
>
>
> Description
> -------
>
> TimerTask::cancel was being called with locks held, causing a deadlock.
> See JIRA for stack trace.
>
> Moved call to cancel() out of the lock.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1363520
> /trunk/qpid/cpp/src/qpid/broker/LinkRegistry.cpp 1363520
>
> Diff: https://reviews.apache.org/r/6092/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alan Conway
>
>