You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org> on 2009/07/20 15:01:21 UTC
[jira] Created: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
QuorumHierarchical does not count groups correctly
--------------------------------------------------
Key: ZOOKEEPER-479
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
Project: Zookeeper
Issue Type: Bug
Components: quorum
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
Fix For: 3.2.1
QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Attachment: ZOOKEEPER-479.patch
ZOOKEEPER-479-branch3.2.patch
Made a small modification to the test in the patch, and uploading a 3.2 version.
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479-branch3.2.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-479:
-----------------------------------
Status: Open (was: Patch Available)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Status: Open (was: Patch Available)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Status: Open (was: Patch Available)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-479:
-----------------------------------
Status: Patch Available (was: Open)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Status: Patch Available (was: Open)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Attachment: ZOOKEEPER-479.patch
This patch fixes this issue and adds one more test.
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-479:
-----------------------------------
Status: Patch Available (was: Open)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Status: Patch Available (was: Open)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738966#action_12738966 ]
Hudson commented on ZOOKEEPER-479:
----------------------------------
Integrated in ZooKeeper-trunk #404 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/404/])
. QuorumHierarchical does not count groups correctly (flavio via mahadev)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479-branch3.2.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Attachment: ZOOKEEPER-479.patch
This patch will probably keep failing until we have ZOOKEEPER-481 in. Also, I'm adding support to get the weight of servers to QuorumVerifiers, which we'll need in ZOOKEEPER-491.
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Flavio Paiva Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Paiva Junqueira updated ZOOKEEPER-479:
---------------------------------------------
Status: Patch Available (was: Open)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479-branch3.2.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737039#action_12737039 ]
Hadoop QA commented on ZOOKEEPER-479:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12414004/ZOOKEEPER-479.patch
against trunk revision 798038.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/158/console
This message is automatically generated.
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-479:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. thanks flavio !!
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479-branch3.2.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-479:
-----------------------------------
Status: Open (was: Patch Available)
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-479:
-----------------------------------
Fix Version/s: 3.3.0
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-479) QuorumHierarchical does not count
groups correctly
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-479:
------------------------------------
Hadoop Flags: [Reviewed]
+1 looks good.
> QuorumHierarchical does not count groups correctly
> --------------------------------------------------
>
> Key: ZOOKEEPER-479
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-479
> Project: Zookeeper
> Issue Type: Bug
> Components: quorum
> Reporter: Flavio Paiva Junqueira
> Assignee: Flavio Paiva Junqueira
> Fix For: 3.2.1, 3.3.0
>
> Attachments: ZOOKEEPER-479.patch, ZOOKEEPER-479.patch
>
>
> QuorumHierarchical::containsQuorum should not verify if all groups represented in the input set have more than half of the total weight. Instead, it should check only for an overall majority of groups.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.