[GitHub] [incubator-superset] villebro commented on a change in pull request #10171: fix: return slice owners for /user_slices ep

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #10171:
URL: https://github.com/apache/incubator-superset/pull/10171#discussion_r446173198



##########
File path: superset/views/core.py
##########
@@ -1380,10 +1380,17 @@ def created_dashboards(  # pylint: disable=no-self-use
     def user_slices(  # pylint: disable=no-self-use
         self, user_id: Optional[int] = None
     ) -> FlaskResponse:
-        """List of slices a user created, or faved"""
+        """List of slices a user owns or faved"""
         if not user_id:
             user_id = g.user.id
         FavStar = models.FavStar
+

Review comment:
       I agree, and I was surprised by the signature. There's a few similar endpoints under `views`, perhaps tackle those in one go in a separate PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org