You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Andrew Mashenkov (JIRA)" <ji...@apache.org> on 2019/03/04 12:13:00 UTC
[jira] [Commented] (IGNITE-11277) Use maven plugin as default code
style checker for project
[ https://issues.apache.org/jira/browse/IGNITE-11277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783319#comment-16783319 ]
Andrew Mashenkov commented on IGNITE-11277:
-------------------------------------------
I see TW-58504 is Fixed in TC version 2018.2.2 and we already have updated version, but Inspection Core still failed.
Is there some another issue that should be fixed? Have someone investigate this?
> Use maven plugin as default code style checker for project
> ----------------------------------------------------------
>
> Key: IGNITE-11277
> URL: https://issues.apache.org/jira/browse/IGNITE-11277
> Project: Ignite
> Issue Type: Task
> Reporter: Maxim Muzafarov
> Assignee: Maxim Muzafarov
> Priority: Major
> Labels: inspections
> Fix For: 2.8
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, {{[Inspections] Core suite}} [1] on TC doesn't work well enough. The suite has a {{FAILED}} status for more than 2 months due to some issues on TeamCity application [2]. It confuses most of the members of the Apache Ignite community.
> Moreover, this suite is no longer checks configured rules. For instance, in the master branch, 11 {{Unused imports}} can be found (e.g. for {{IgniteCachePutAllRestartTest}
> [3]).
> I think the maven-checkstyle-plugin should be used as the default code style checker.
> _Advantages:_
> * An IDE agnostic way for code checks
> * Can be used with different CI and build tools
> * Executable from the command line
> * Single configuration
> [1] https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_InspectionsCore&branch_IgniteTests24Java8=%3Cdefault%3E&tab=buildTypeStatusDiv
> [2] https://youtrack.jetbrains.com/issue/TW-58504
> [3] https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/internal/processors/cache/IgniteCachePutAllRestartTest.java#L29
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)