[jira] [Commented] (AIRFLOW-3107) Create Dynamic External Task Sensor to handle non exact timeframes

["Iuliia Volkova (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639358#comment-16639358 ] 

Iuliia Volkova commented on AIRFLOW-3107:
-----------------------------------------

[~bdesmet], Do I right understand, what you want to add those code to apache-airflow master or discuss of need it to be add to apache-airflow master? If it so, best way is to open PR and mentioned in this task somebody of contributors team. 
But I'm not sure, what make sense to do it like different Sensor,  for me maybe more better way was to add data_range param in TimeRangeExternalTaskSensor, and use for this https://pandas.pydata.org/pandas-docs/stable/generated/pandas.date_range.html for example, it's not a problem because Airflow anyway depend on pandas like instal requirement. I'm not sure what here is needed separate Sensor. 

[~ashb], [~Fokko], hi guys! Maybe you can take a look on this sensor, need it to be add or not?

> Create Dynamic External Task Sensor to handle non exact timeframes
> ------------------------------------------------------------------
>
>                 Key: AIRFLOW-3107
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3107
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: core
>    Affects Versions: 2.0.0
>            Reporter: Bert Desmet
>            Priority: Major
>              Labels: dependencies, dynamic_dependencies, sensors
>             Fix For: 2.0.0
>
>
> All, 
> For a project I'm working on it is necessary to check if a specific task has run somewhere between 30 days ago and now. 
> To facilitate this I have patched airflow to include the 'TimeRangeExternalTaskSensor'  as provided by {color:#333333}[omnilinguist|https://github.com/omnilinguist] in the following pull request: [https://github.com/apache/incubator-airflow/pull/1641] {color}
> I have updated his code so it aligns better with how the ExternalTaskSensor has been implemented. 
> Currently we are running this patch in production on a 1.9 version of Airflow. I have now merged this with the master branch - but this code has not yet fully been tested. 
>  
> The code can be found here:  [https://github.com/biertie/incubator-airflow/blob/master/airflow/sensors/time_range_external_task_sensor.py]
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)