You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/02/26 06:06:29 UTC
Review Request 44055: Hide Custom configuration category for files
which does not support custom configuration in HAWQ and PXF
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
Bugs: AMBARI-15175
https://issues.apache.org/jira/browse/AMBARI-15175
Repository: ambari
Description
-------
This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
Diffs
-----
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml 324a3d8
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml d8917e6
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 32ae5a5
ambari-web/app/models/stack_service.js d9edf6e
Diff: https://reviews.apache.org/r/44055/diff/
Testing
-------
yes. manual.
Thanks,
bhuvnesh chaudhary
Re: Review Request 44055: Hide Custom configuration category for
files which does not support custom configuration in HAWQ and PXF
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review121322
-----------------------------------------------------------
ambari-web/app/models/stack_service.js (line 402)
<https://reviews.apache.org/r/44055/#comment183006>
Good stuff!
- jun aoki
On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 6:11 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
>
>
> Diffs
> -----
>
> ambari-web/app/models/stack_service.js d9edf6e
>
> Diff: https://reviews.apache.org/r/44055/diff/
>
>
> Testing
> -------
>
> yes. manual.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 44055: Hide Custom configuration category for
files which does not support custom configuration in HAWQ and PXF
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review121323
-----------------------------------------------------------
Ship it!
Ship It!
- jun aoki
On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 6:11 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
>
>
> Diffs
> -----
>
> ambari-web/app/models/stack_service.js d9edf6e
>
> Diff: https://reviews.apache.org/r/44055/diff/
>
>
> Testing
> -------
>
> yes. manual.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 44055: Hide Custom configuration category for
files which does not support custom configuration in HAWQ and PXF
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review121068
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On Feb. 25, 2016, 10:11 p.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 10:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
>
>
> Diffs
> -----
>
> ambari-web/app/models/stack_service.js d9edf6e
>
> Diff: https://reviews.apache.org/r/44055/diff/
>
>
> Testing
> -------
>
> yes. manual.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 44055: Hide Custom configuration category for
files which does not support custom configuration in HAWQ and PXF
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/
-----------------------------------------------------------
(Updated Feb. 26, 2016, 6:11 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
Changes
-------
Updated diff
Bugs: AMBARI-15175
https://issues.apache.org/jira/browse/AMBARI-15175
Repository: ambari
Description
-------
This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
Diffs (updated)
-----
ambari-web/app/models/stack_service.js d9edf6e
Diff: https://reviews.apache.org/r/44055/diff/
Testing
-------
yes. manual.
Thanks,
bhuvnesh chaudhary
Re: Review Request 44055: Hide Custom configuration category for
files which does not support custom configuration in HAWQ and PXF
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
> On Feb. 26, 2016, 5:26 a.m., Matt wrote:
> > ambari-web/app/models/stack_service.js, line 402
> > <https://reviews.apache.org/r/44055/diff/1/?file=1271824#file1271824line402>
> >
> > May I know why the pxf config filenames ended up here, but the HAWQ config files have an additional attribute (as in trunk)?
> >
> > Curious why it worked for HAWQ but not PXF...
>
> bhuvnesh chaudhary wrote:
> Good point. PXF does not have -env at the end of the files added up here.
> And this logic automatically takes care of files ending with -env, so we don't need supports_adding_forbidden for them in the *xml.
And this logic automatically takes care of files ending with -env, so we don't need supports_adding_forbidden for HAWQ *-env.xml, removed.
- bhuvnesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review120830
-----------------------------------------------------------
On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 6:11 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
>
>
> Diffs
> -----
>
> ambari-web/app/models/stack_service.js d9edf6e
>
> Diff: https://reviews.apache.org/r/44055/diff/
>
>
> Testing
> -------
>
> yes. manual.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 44055: Hide Custom configuration category for
files which does not support custom configuration in HAWQ and PXF
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
> On Feb. 26, 2016, 5:26 a.m., Matt wrote:
> > ambari-web/app/models/stack_service.js, line 402
> > <https://reviews.apache.org/r/44055/diff/1/?file=1271824#file1271824line402>
> >
> > May I know why the pxf config filenames ended up here, but the HAWQ config files have an additional attribute (as in trunk)?
> >
> > Curious why it worked for HAWQ but not PXF...
Good point. PXF does not have -env at the end of the files added up here.
And this logic automatically takes care of files ending with -env, so we don't need supports_adding_forbidden for them in the *xml.
- bhuvnesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review120830
-----------------------------------------------------------
On Feb. 26, 2016, 6:11 a.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 6:11 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
>
>
> Diffs
> -----
>
> ambari-web/app/models/stack_service.js d9edf6e
>
> Diff: https://reviews.apache.org/r/44055/diff/
>
>
> Testing
> -------
>
> yes. manual.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>
Re: Review Request 44055: Hide Custom configuration category for
files which does not support custom configuration in HAWQ and PXF
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44055/#review120830
-----------------------------------------------------------
ambari-web/app/models/stack_service.js (line 402)
<https://reviews.apache.org/r/44055/#comment182340>
May I know why the pxf config filenames ended up here, but the HAWQ config files have an additional attribute (as in trunk)?
Curious why it worked for HAWQ but not PXF...
- Matt
On Feb. 25, 2016, 9:06 p.m., bhuvnesh chaudhary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44055/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 9:06 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jayush Luniya, Oleksandr Diachenko, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15175
> https://issues.apache.org/jira/browse/AMBARI-15175
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This minor patch hides custom configuration category for files which does not support custom configuration in HAWQ and PXF
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-env.xml 324a3d8
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-limits-env.xml d8917e6
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml 32ae5a5
> ambari-web/app/models/stack_service.js d9edf6e
>
> Diff: https://reviews.apache.org/r/44055/diff/
>
>
> Testing
> -------
>
> yes. manual.
>
>
> Thanks,
>
> bhuvnesh chaudhary
>
>