[GitHub] [spark] ulysses-you commented on a diff in pull request #41454: [SPARK-43376][SQL][FOLLOWUP] lazy construct subquery to improve reuse subquery

["ulysses-you (via GitHub)" <gi...@apache.org>]

ulysses-you commented on code in PR #41454:
URL: https://github.com/apache/spark/pull/41454#discussion_r1218779156


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/InsertAdaptiveSparkPlan.scala:
##########
@@ -137,26 +139,17 @@ case class InsertAdaptiveSparkPlan(
           if !subqueryMap.contains(exprId.id) =>
         val executedPlan = compileSubquery(p)
         verifyAdaptivePlan(executedPlan, p)
-        val subquery = SubqueryExec.createForScalarSubquery(
-          s"subquery#${exprId.id}", executedPlan)
-        subqueryMap.put(exprId.id, subquery)
+        subqueryMap.put(exprId.id, executedPlan)

Review Comment:
   yeas, cleaned up these code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org