[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6552: removed the use of SharedMountPoint storage type for the StorPool plugin

[GitBox <gi...@apache.org>]

GutoVeronezi commented on code in PR #6552:
URL: https://github.com/apache/cloudstack/pull/6552#discussion_r936686436


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2868,7 +2869,8 @@ public int compare(final DiskTO arg0, final DiskTO arg1) {
                     && (pool.getType() == StoragePoolType.NetworkFilesystem
                     || pool.getType() == StoragePoolType.SharedMountPoint
                     || pool.getType() == StoragePoolType.Filesystem
-                    || pool.getType() == StoragePoolType.Gluster)) {
+                    || pool.getType() == StoragePoolType.Gluster
+                    || pool.getType() == StoragePoolType.StorPool)) {

Review Comment:
   We could create a `Set` with the types allowed and verify if it "contains", to reduce the `if` complexity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org