You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/08/17 09:47:25 UTC

[GitHub] wu-sheng commented on issue #1554: Fix #1549, spring-plugins bug

wu-sheng commented on issue #1554: Fix  #1549,  spring-plugins bug
URL: https://github.com/apache/incubator-skywalking/pull/1554#issuecomment-413815398
 
 
   > I think that this is not the root cause about #1549, I suspect that the problem is caused by that the plugin only stores the Request and does not store Response。because of the plugin had check if Request is empty when creating span in beforeMethod and the plugin check the Response is empty when finish the span in afterMethod.
   
   Can you provide more detail or another fix for this? If plugin checked, where does the span come from? Any other plugin leak the span?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services