You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2010/07/16 23:40:50 UTC
[jira] Created: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
nodetool ring prints incorrect IP address
-----------------------------------------
Key: CASSANDRA-1291
URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.7
Reporter: Brandon Williams
Priority: Minor
Fix For: 0.7
Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-1291) nodetool ring prints
incorrect IP address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903874#action_12903874 ]
Brandon Williams edited comment on CASSANDRA-1291 at 8/28/10 2:57 PM:
----------------------------------------------------------------------
I tried to replicate this one more time with a keyspace at RF=2, as Christopher suggested, which had worked in the past. It no longer works, so I think CASSANDRA-1286 solved this.
was (Author: brandon.williams):
I tried to replicate this one more time with a keyspace at RF=2, as Chrisopher suggested, which had worked in the past. It no longer works, so I think CASSANDRA-1286 solved this.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 2
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams reopened CASSANDRA-1291:
-----------------------------------------
Reverted previous fix, as this doesn't solve anything when testing with RF=2. I think Christopher's comment is correct; waiting to see what happens with CASSANDRA-1286 since it's related.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894938#action_12894938 ]
Brandon Williams commented on CASSANDRA-1291:
---------------------------------------------
Jignesh,
The latest trunk works for you now though, correct?
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895305#action_12895305 ]
Jonathan Ellis commented on CASSANDRA-1291:
-------------------------------------------
The confusing thing to me is that while I can picture situations where code assumes the first node from calculateNaturalEndpoints is special, nodetool ring doesn't hit calculateNaturalEndpoints at all [it's calculated purely from StorageService's TokenMetadata]. So I don't see how LHS vs HS should matter at all.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894772#action_12894772 ]
Jonathan Ellis commented on CASSANDRA-1291:
-------------------------------------------
Jignesh: why should order the items are added to the Set be significant?
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Nick Bailey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893349#action_12893349 ]
Nick Bailey commented on CASSANDRA-1291:
----------------------------------------
I believe Jignesh's change is almost certainly the problem. It's not consistently reproduceable because it depends on the hash value of the endpoint.
Jignesh, you should modify RackUnawareStrategy as well and attach and submit the patch.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Fix For: 0.7 beta 1
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1291.
---------------------------------------
Resolution: Cannot Reproduce
Came up empty asking on IRC if anyone testing 0.7 was seeing this. Closing as cannot reproduce until someone can.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Jeremy Hanna
> Fix For: 0.7 beta 2
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895307#action_12895307 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
I believe it does.
I did put some debugging statements in calculateNaturalEndpoints in RackAwareStrategy before and that is when I realized that the problem is in the way endpoints are stored.
So here is my usecase:
I started up a new cluster, no data has been inserted yet. I create the schema with RF=3 on one node which gets replicated on all other nodes. Now I run the nodetool ring command and I see incorrect/duplicate ips in the ring command.
Changing HashSet back to LinkedHashSet does solve the problem.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-1291) nodetool ring prints
incorrect IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892370#action_12892370 ]
Jignesh Dhruv edited comment on CASSANDRA-1291 at 7/26/10 12:58 PM:
--------------------------------------------------------------------
I downloaded the latest source code from trunk and I still get nodetool to print out the same node multiple times in a cluster. It misses certain nodes and instead of that, it show me the same node 3 or 4 times. I use RackAwareStrategy with 14 nodes.
I am not getting any problems with the fix that I described above where I am converting HashSet to LinkedHashSet thus preserving the nodes order.
was (Author: jigneshdhruv):
I downloaded the latest source code from trunk and I still get nodetool to print out the same nde multiple times in a cluster. It misses certain nodes and instead of that, it show me the same node 3 or 4 times. I use RackAwareStrategy with 14 nodes.
I am not getting any problems with the fix that I described above where I am converting HashSet to LinkedHashSet thus preserving the nodes order.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Fix For: 0.7 beta 1
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895043#action_12895043 ]
Brandon Williams commented on CASSANDRA-1291:
---------------------------------------------
Oops, turns out I never reverted the patch in this ticket like I said I did. It's reverted now, let me know if the issue reappears.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Christopher Gist (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893254#action_12893254 ]
Christopher Gist commented on CASSANDRA-1291:
---------------------------------------------
I have also observed nodetool ring reporting duplicate IPs on the latest trunk. This was with a 2 node cluster and a keyspace with RF=2 and RackUnawareStrategy. The correct IPs were reported with getLiveNodes via JMX.
After adding a keyspace with RF=1, the output of nodetool ring is as expected with the correct IPs.
I think this behaviour might be related to nodetool ring using the range of the first non-system keyspace in StorageService.getRangeToEndpointMap(null).
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Fix For: 0.7 beta 1
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894729#action_12894729 ]
Gary Dusbabek commented on CASSANDRA-1291:
------------------------------------------
I can no longer reproduce this with CASSANDRA-1286 applied.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894810#action_12894810 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
Hi Jonathan,
What I am seeing is that with RF=2 or more and endpoints being HashSet, displays incorrect nodes/ip in the nodetool ring command. Changing HashSet to LinkedHashSet displays ring correctly with unique ip addresses. I rely on nodetool ring command to determine what nodes are up and their load distribution.
Let me know if I have not answered your question?
Thanks,
Jignesh
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895309#action_12895309 ]
Jonathan Ellis commented on CASSANDRA-1291:
-------------------------------------------
I understand that HS -> LHS solves the problem for you, but if we don't understand *why* then we cannot close the bug.
Please include a stack trace (e.g. from printStackTrace) from ring to your calculateNaturalEndpoints, because I set a breakpoint there and nodetool ring is not hitting it.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893247#action_12893247 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
I see this error when running nodetool ring command. The same node appears multiple times and as a result when you bring up or down some nodes it gives you incorrect information. We rely on nodetool for monitoring and were hoping that the ring command shows the accurate picture of all the nodes in the cluster.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Fix For: 0.7 beta 1
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-1291:
----------------------------------------
Attachment: 1291.txt
Attachment with Jignesh's consolidated changes.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894738#action_12894738 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
With the fix I suggested above, I had no isses with nodetool ring with RF=3.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1291:
--------------------------------------
Assignee: Brandon Williams (was: Jeremy Hanna)
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 2
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams reassigned CASSANDRA-1291:
-------------------------------------------
Assignee: Brandon Williams
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895019#action_12895019 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
Yes it does work for me.
Thanks for committing the patch in.
Jignesh
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890466#action_12890466 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
So bug https://issues.apache.org/jira/browse/CASSANDRA-1304 has been marked duplicate of this bug.
But there is a major issue that I am seeing. The load is being divided among the nodes that are seen through nodetool ring command while some of the nodes in the cluster hardly have 2% of data. These are the nodes that are not visible through ring command.
When I run the loadbalance command, the data gets transferred again to a node that is visible in the ring command. The nodes that are not visible in the ring command has minimal of less than 10% of data. load-balance also doesn't help in this case.
Thus in my cluster of 7 nodes, 3 nodes has 90$ of data and other 4 nodes has 10% of data. And when I run loadbalance data keeps getting transferred within the top 3 nodes.
I am changing the priority to major. Again I am seeing this issue only with DatacenterShardStrategy.
Jignesh
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Brandon Williams
> Priority: Minor
> Fix For: 0.7
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892301#action_12892301 ]
Brandon Williams commented on CASSANDRA-1291:
---------------------------------------------
No longer reproduces on trunk for me.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Fix For: 0.7 beta 1
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892370#action_12892370 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
I downloaded the latest source code from trunk and I still get nodetool to print out the same nde multiple times in a cluster. It misses certain nodes and instead of that, it show me the same node 3 or 4 times. I use RackAwareStrategy with 14 nodes.
I am not getting any problems with the fix that I described above where I am converting HashSet to LinkedHashSet thus preserving the nodes order.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Fix For: 0.7 beta 1
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Nick Bailey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892978#action_12892978 ]
Nick Bailey commented on CASSANDRA-1291:
----------------------------------------
Do you have any moves taking place when you see this error?
Looks like we include pending ranges in the output. Pending ranges are stored in a HashMultimap which uses a Hashset to store the collection of values for each key. Since HashSet doesn't guarantee order that could be the issue here.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Fix For: 0.7 beta 1
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jignesh Dhruv reopened CASSANDRA-1291:
--------------------------------------
Its not working again. nodetool is displaying wrong IP in the ring command.
I see that you reverted back to use HashSet instead of LinkedHashSet and I believe that is where the problem is.
I had no issues with the last svn revision, writes/reads all were working great with that revision too.
Reopening the issue.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903874#action_12903874 ]
Brandon Williams commented on CASSANDRA-1291:
---------------------------------------------
I tried to replicate this one more time with a keyspace at RF=2, as Chrisopher suggested, which had worked in the past. It no longer works, so I think CASSANDRA-1286 solved this.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 2
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894269#action_12894269 ]
Hudson commented on CASSANDRA-1291:
-----------------------------------
Integrated in Cassandra #505 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/505/])
Use LinkedHashSet in location strategies to maintain order. Patch by Jignesh Dhruv reviewed by brandonwilliams for CASSANDRA-1291
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Hanna reassigned CASSANDRA-1291:
---------------------------------------
Assignee: Jeremy Hanna (was: Brandon Williams)
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Jeremy Hanna
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams resolved CASSANDRA-1291.
-----------------------------------------
Resolution: Fixed
Solved by CASSANDRA-1286
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1291) nodetool ring prints incorrect IP
address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jignesh Dhruv updated CASSANDRA-1291:
-------------------------------------
Priority: Major (was: Minor)
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Brandon Williams
> Fix For: 0.7
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Arya Goudarzi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894652#action_12894652 ]
Arya Goudarzi commented on CASSANDRA-1291:
------------------------------------------
https://issues.apache.org/jira/browse/CASSANDRA-1341
Was marked as duplicate of this issue. However my scenario is a bit different. Thought that might bring some new insight.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7 beta 1
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 0.7 beta 1
>
> Attachments: 1291.txt
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1291) nodetool ring prints incorrect
IP address
Posted by "Jignesh Dhruv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890470#action_12890470 ]
Jignesh Dhruv commented on CASSANDRA-1291:
------------------------------------------
Also when I run loadbalancing with DatacenterShardStrategy data does get transferred to one of the node visible in the nodetool ring command in the datacenter. And once the streaming is complete, data from DC1 gets transferred to this node in DC2.
> nodetool ring prints incorrect IP address
> -----------------------------------------
>
> Key: CASSANDRA-1291
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1291
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Brandon Williams
> Fix For: 0.7
>
>
> Nodetool's ring output on trunk seems to duplicate an ipaddress instead of printing them all.
> To reproduce: spin up a 3 node cluster and create a keyspace, examine nodetool ring. One ip address will show up twice, though the tokens are correctly displayed for the three machines.
> This is a cosmetic error, if you call getLiveNodes via JMX you can see all three IPs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.