You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/12 11:48:16 UTC
[GitHub] [skywalking-banyandb-java-client] hanahmily opened a new pull request, #18: Bump up proto files
hanahmily opened a new pull request, #18:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/18
Fixes https://github.com/apache/skywalking/issues/9761
- [x] Update proto files
- [x] Update related components
- [ ] Update UTs
- [ ] Update ITs
Signed-off-by: Gao Hongtao <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on a diff in pull request #18: Bump up proto files
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #18:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/18#discussion_r997662800
##########
CHANGES.md:
##########
@@ -8,8 +8,16 @@ Release Notes.
### Features
+- Support `indexed_only` flag to the tag specification.
+- Support `Analyzer` to the index rule.
+- Add `exist` endpoints to the metadata registry.
+- Set `CompletableFuture<Void>` to the return type of write processor.
Review Comment:
@kezhenxu94 could you recheck this part? Whether is it suitable for OAP writing and self-obs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] kezhenxu94 commented on a diff in pull request #18: Bump up proto files
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #18:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/18#discussion_r997782670
##########
CHANGES.md:
##########
@@ -8,8 +8,16 @@ Release Notes.
### Features
+- Support `indexed_only` flag to the tag specification.
+- Support `Analyzer` to the index rule.
+- Add `exist` endpoints to the metadata registry.
+- Set `CompletableFuture<Void>` to the return type of write processor.
Review Comment:
I think this is good in OAP side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng merged pull request #18: Bump up proto files
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #18:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb-java-client] wu-sheng commented on pull request #18: Bump up proto files
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #18:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/18#issuecomment-1276032999
There should be some README doc update, right? We have some breaking changes in 0.2.0 APIs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org