You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/02/20 21:21:01 UTC

[GitHub] csantanapr commented on issue #97: Added maven archetype for Java Action

csantanapr commented on issue #97: Added maven archetype for Java Action
URL: https://github.com/apache/incubator-openwhisk-devtools/pull/97#issuecomment-367123547
 
 
   HI @kameshsampath this tools are very good to have, but I'm concern that they don't have any test validation.
   If someone submits a PR to modify any of it I would not have confidence on merging since it's not tied into Travis.
   
   Could you add tests to this new `java-action-archetype/` in addition to the previous `/maven-java/`
   
   Not sure if both are related so one single test suite will do.
   And then hook them into travis
   
   Here is some example of @gorkem did in terms of tests for example:
   https://github.com/apache/incubator-openwhisk-devtools/tree/master/java-local/src/test
   
   Hey @gorkem would you mind hooking Travis to run your tests?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services