You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/24 14:49:09 UTC
[GitHub] [dubbo-go-pixiu] williamfeng323 opened a new pull request #256: Feature/registry listener
williamfeng323 opened a new pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#issuecomment-931338183
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#256](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e00dd1) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/7e8add1fd86b77bd311bad6b901eb8b8d4c305ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e8add1) will **decrease** coverage by `6.04%`.
> The diff coverage is `15.92%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #256 +/- ##
===========================================
- Coverage 39.75% 33.71% -6.05%
===========================================
Files 50 56 +6
Lines 2568 3245 +677
===========================================
+ Hits 1021 1094 +73
- Misses 1436 2039 +603
- Partials 111 112 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dapter/dubboregistry/registry/base/baseregistry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS9iYXNlL2Jhc2VyZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...egistry/registry/zookeeper/application\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fbGlzdGVuZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
| [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `67.64% <0.00%> (ø)` | |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `54.16% <0.00%> (-2.36%)` | :arrow_down: |
| [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <0.00%> (-0.14%)` | :arrow_down: |
| [pkg/server/api\_config\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hcGlfY29uZmlnX21hbmFnZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e8add1...6e00dd1](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#issuecomment-931338183
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#256](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f968e6) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/fa5681d94aa6d7a0d81f12bd469a77b624d4deb2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa5681d) will **decrease** coverage by `1.81%`.
> The diff coverage is `27.32%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #256 +/- ##
===========================================
- Coverage 36.39% 34.57% -1.82%
===========================================
Files 36 56 +20
Lines 1937 3184 +1247
===========================================
+ Hits 705 1101 +396
- Misses 1137 1970 +833
- Partials 95 113 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dapter/dubboregistry/registry/base/baseregistry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS9iYXNlL2Jhc2VyZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `21.48% <0.00%> (+0.72%)` | :arrow_up: |
| [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (+2.31%)` | :arrow_up: |
| [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `42.16% <0.00%> (-5.46%)` | :arrow_down: |
| [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (+2.43%)` | :arrow_up: |
| [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (+2.00%)` | :arrow_up: |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-34.39%)` | :arrow_down: |
| [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <0.00%> (+0.65%)` | :arrow_up: |
| ... and [71 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa5681d...4f968e6](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#issuecomment-931338183
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#256](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e613e9) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/7e8add1fd86b77bd311bad6b901eb8b8d4c305ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e8add1) will **decrease** coverage by `5.17%`.
> The diff coverage is `15.89%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #256 +/- ##
===========================================
- Coverage 39.75% 34.57% -5.18%
===========================================
Files 50 56 +6
Lines 2568 3184 +616
===========================================
+ Hits 1021 1101 +80
- Misses 1436 1970 +534
- Partials 111 113 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dapter/dubboregistry/registry/base/baseregistry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS9iYXNlL2Jhc2VyZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
| [pkg/server/api\_config\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hcGlfY29uZmlnX21hbmFnZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/server/listener\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lcl9tYW5hZ2VyLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/server/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9waXhpdV9zdGFydC5nbw==) | `0.00% <0.00%> (ø)` | |
| [...adapter/dubboregistry/remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZW1vdGluZy96b29rZWVwZXIvY2xpZW50Lmdv) | `16.56% <16.56%> (ø)` | |
| [...oregistry/registry/zookeeper/interface\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvaW50ZXJmYWNlX2xpc3RlbmVyLmdv) | `32.50% <32.50%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e8add1...0e613e9](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#issuecomment-931338183
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#256](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4121b0d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/fa5681d94aa6d7a0d81f12bd469a77b624d4deb2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fa5681d) will **decrease** coverage by `1.81%`.
> The diff coverage is `27.32%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #256 +/- ##
===========================================
- Coverage 36.39% 34.57% -1.82%
===========================================
Files 36 56 +20
Lines 1937 3184 +1247
===========================================
+ Hits 705 1101 +396
- Misses 1137 1970 +833
- Partials 95 113 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dapter/dubboregistry/registry/base/baseregistry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS9iYXNlL2Jhc2VyZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/client/dubbo/dubbo.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9kdWJiby5nbw==) | `21.48% <0.00%> (+0.72%)` | :arrow_up: |
| [pkg/client/dubbo/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9kdWJiby9tYXBwZXIuZ28=) | `69.23% <ø> (+2.31%)` | :arrow_up: |
| [pkg/client/http/http.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL2h0dHAuZ28=) | `42.16% <0.00%> (-5.46%)` | :arrow_down: |
| [pkg/client/http/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9odHRwL21hcHBlci5nbw==) | `72.72% <ø> (+2.43%)` | :arrow_up: |
| [pkg/client/mapper.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NsaWVudC9tYXBwZXIuZ28=) | `80.95% <ø> (+2.00%)` | :arrow_up: |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `56.52% <0.00%> (-34.39%)` | :arrow_down: |
| [pkg/config/api\_config.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmZpZy9hcGlfY29uZmlnLmdv) | `3.13% <0.00%> (+0.65%)` | :arrow_up: |
| ... and [71 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fa5681d...4121b0d](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#issuecomment-931338183
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#256](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (64a1f4c) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/7e8add1fd86b77bd311bad6b901eb8b8d4c305ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e8add1) will **decrease** coverage by `6.06%`.
> The diff coverage is `15.87%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #256 +/- ##
===========================================
- Coverage 39.75% 33.69% -6.07%
===========================================
Files 50 56 +6
Lines 2568 3247 +679
===========================================
+ Hits 1021 1094 +73
- Misses 1436 2041 +605
- Partials 111 112 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dapter/dubboregistry/registry/base/baseregistry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS9iYXNlL2Jhc2VyZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...egistry/registry/zookeeper/application\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fbGlzdGVuZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
| [pkg/common/http/manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9odHRwL21hbmFnZXIuZ28=) | `67.64% <0.00%> (ø)` | |
| [pkg/common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi95YW1sL3lhbWwuZ28=) | `54.16% <0.00%> (-2.36%)` | :arrow_down: |
| [pkg/context/http/context.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbnRleHQvaHR0cC9jb250ZXh0Lmdv) | `6.18% <0.00%> (-0.14%)` | :arrow_down: |
| [pkg/server/api\_config\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hcGlfY29uZmlnX21hbmFnZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e8add1...64a1f4c](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#issuecomment-931338183
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#256](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ba830d5) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/7e8add1fd86b77bd311bad6b901eb8b8d4c305ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7e8add1) will **decrease** coverage by `6.10%`.
> The diff coverage is `11.66%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #256 +/- ##
===========================================
- Coverage 39.75% 33.65% -6.11%
===========================================
Files 50 56 +6
Lines 2568 3188 +620
===========================================
+ Hits 1021 1073 +52
- Misses 1436 2004 +568
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dapter/dubboregistry/registry/base/baseregistry.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS9iYXNlL2Jhc2VyZWdpc3RyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [...egistry/registry/zookeeper/application\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fbGlzdGVuZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [...registry/zookeeper/application\_service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvYXBwbGljYXRpb25fc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [...bboregistry/registry/zookeeper/service\_listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/common/extension/adapter/adapter.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9leHRlbnNpb24vYWRhcHRlci9hZGFwdGVyLmdv) | `58.33% <ø> (ø)` | |
| [pkg/server/api\_config\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9hcGlfY29uZmlnX21hbmFnZXIuZ28=) | `0.00% <0.00%> (ø)` | |
| [pkg/server/listener.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/server/listener\_manager.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9saXN0ZW5lcl9tYW5hZ2VyLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/server/pixiu\_start.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NlcnZlci9waXhpdV9zdGFydC5nbw==) | `0.00% <0.00%> (ø)` | |
| [...adapter/dubboregistry/remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZW1vdGluZy96b29rZWVwZXIvY2xpZW50Lmdv) | `16.56% <16.56%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7e8add1...ba830d5](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/256?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#discussion_r719962372
##########
File path: pkg/adapter/dubboregistry/registry/zookeeper/interface_listener.go
##########
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package zookeeper
+
+import (
+ "path"
+ "sync"
+ "time"
+)
+
+import (
+ "github.com/apache/dubbo-go/common"
+ "github.com/dubbogo/go-zookeeper/zk"
+)
+
+import (
+ common2 "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/common"
+ "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/registry"
+ "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/remoting/zookeeper"
+ "github.com/apache/dubbo-go-pixiu/pkg/logger"
+)
+
+const (
+ rootPath = "/dubbo"
+ providerCategory = "providers"
+)
+
+var _ registry.Listener = new(zkIntfListener)
+
+type zkIntfListener struct {
+ path string
+ exit chan struct{}
+ client *zookeeper.ZooKeeperClient
+ reg *ZKRegistry
+ wg sync.WaitGroup
+ adapterListener common2.RegistryEventListener
+}
+
+// newZKIntfListener returns a new zkIntfListener with pre-defined path according to the registered type.
+func newZKIntfListener(client *zookeeper.ZooKeeperClient, reg *ZKRegistry, adapterListener common2.RegistryEventListener) registry.Listener {
+ p := rootPath
+ return &zkIntfListener{
+ path: p,
+ exit: make(chan struct{}),
+ client: client,
+ reg: reg,
+ adapterListener: adapterListener,
+ }
+}
+
+func (z *zkIntfListener) Close() {
+ close(z.exit)
+ z.wg.Wait()
+}
+
+func (z *zkIntfListener) WatchAndHandle() {
+ z.wg.Add(1)
+ go z.watch()
+}
+
+func (z *zkIntfListener) watch() {
+ defer z.wg.Done()
+ var (
+ failTimes int64 = 0
+ delayTimer = time.NewTimer(ConnDelay * time.Duration(failTimes))
+ )
+ defer delayTimer.Stop()
+ for {
+ _, e, err := z.client.GetChildrenW(z.path)
+ // error handling
+ if err != nil {
+ failTimes++
+ logger.Infof("watching (path{%s}) = error{%v}", z.path, err)
+ // Exit the watch if root node is in error
+ if err == zookeeper.ErrNilNode {
+ logger.Errorf("watching (path{%s}) got errNilNode,so exit listen", z.path)
+ return
+ }
+ if failTimes > MaxFailTimes {
+ logger.Errorf("Error happens on (path{%s}) exceed max fail times: %s,so exit listen",
+ z.path, MaxFailTimes)
+ return
+ }
+ delayTimer.Reset(ConnDelay * time.Duration(failTimes))
+ <-delayTimer.C
+ continue
+ }
+ failTimes = 0
+ tickerTTL := defaultTTL
+ ticker := time.NewTicker(tickerTTL)
Review comment:
defer ticker.Stop()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#discussion_r719962127
##########
File path: pkg/adapter/dubboregistry/registry/zookeeper/application_listener_test.go
##########
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package zookeeper
+
+//
Review comment:
这个文件全部注释掉，为啥？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#discussion_r719961959
##########
File path: pkg/adapter/dubboregistry/registry/zookeeper/application_listener.go
##########
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package zookeeper
+
+import (
+ "strings"
+ "sync"
+ "time"
+)
+
+import (
+ _ "github.com/apache/dubbo-go/cluster/cluster_impl"
+ _ "github.com/apache/dubbo-go/cluster/loadbalance"
+ _ "github.com/apache/dubbo-go/common/proxy/proxy_factory"
+ _ "github.com/apache/dubbo-go/filter/filter_impl"
+ _ "github.com/apache/dubbo-go/metadata/service/inmemory"
+ _ "github.com/apache/dubbo-go/metadata/service/remote"
+ _ "github.com/apache/dubbo-go/registry/protocol"
+ _ "github.com/apache/dubbo-go/registry/zookeeper"
+ "github.com/dubbogo/go-zookeeper/zk"
+)
+
+import (
+ "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/common"
+ "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/registry"
+ "github.com/apache/dubbo-go-pixiu/pkg/adapter/dubboregistry/remoting/zookeeper"
+ "github.com/apache/dubbo-go-pixiu/pkg/common/constant"
+ "github.com/apache/dubbo-go-pixiu/pkg/logger"
+)
+
+const (
+ defaultServicesPath = "/services"
+ methodsRootPath = "/dubbo/metadata"
+)
+
+var _ registry.Listener = new(zkAppListener)
+
+type zkAppListener struct {
+ servicesPath string
+ exit chan struct{}
+ client *zookeeper.ZooKeeperClient
+ reg *ZKRegistry
+ wg sync.WaitGroup
+ adapterListener common.RegistryEventListener
+}
+
+// newZkAppListener returns a new newZkAppListener with pre-defined servicesPath according to the registered type.
+func newZkAppListener(client *zookeeper.ZooKeeperClient, reg *ZKRegistry, adapterListener common.RegistryEventListener) registry.Listener {
+ p := defaultServicesPath
+ return &zkAppListener{
+ servicesPath: p,
+ exit: make(chan struct{}),
+ client: client,
+ reg: reg,
+ adapterListener: adapterListener,
+ }
+}
+
+func (z *zkAppListener) Close() {
+ close(z.exit)
+ z.wg.Wait()
+}
+
+func (z *zkAppListener) WatchAndHandle() {
+ z.wg.Add(1)
+ go z.watch()
+}
+
+func (z *zkAppListener) watch() {
+ defer z.wg.Done()
+
+ var (
+ failTimes int64 = 0
+ delayTimer = time.NewTimer(ConnDelay * time.Duration(failTimes))
+ )
+ defer delayTimer.Stop()
+ for {
+ children, e, err := z.client.GetChildrenW(z.servicesPath)
+ // error handling
+ if err != nil {
+ failTimes++
+ logger.Infof("watching (path{%s}) = error{%v}", z.servicesPath, err)
+ // Exit the watch if root node is in error
+ if err == zookeeper.ErrNilNode {
+ logger.Errorf("watching (path{%s}) got errNilNode,so exit listen", z.servicesPath)
+ return
+ }
+ if failTimes > MaxFailTimes {
+ logger.Errorf("Error happens on (path{%s}) exceed max fail times: %s,so exit listen",
+ z.servicesPath, MaxFailTimes)
+ return
+ }
+ delayTimer.Reset(ConnDelay * time.Duration(failTimes))
+ <-delayTimer.C
+ continue
+ }
+ failTimes = 0
+ tickerTTL := defaultTTL
+ ticker := time.NewTicker(tickerTTL)
Review comment:
defer ticker.Stop()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] ztelur commented on a change in pull request #256: Feature/registry listener
Posted by GitBox <gi...@apache.org>.
ztelur commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-pixiu/pull/256#discussion_r720613993
##########
File path: pkg/adapter/dubboregistry/registry/zookeeper/application_listener_test.go
##########
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package zookeeper
+
+//
Review comment:
应用级服务发现的相关逻辑暂时去掉了，放在下一个迭代
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org